[TECH DEBT] Let LocalFileLinter reuse the Dependency instead falling back on its path
#3641
+81
−154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JCZuurmond
added
pr/do-not-merge
JCZuurmond
temporarily deployed
to
account-admin
GitHub Actions
Inactive
|
✅ 57/57 passed, 2 skipped, 26m37s total Running from acceptance #8200 |
4 tasks
pritishpai
approved these changes
Feb 5, 2025
JCZuurmond
temporarily deployed
to
account-admin
GitHub Actions
Inactive
JCZuurmond
commented
Feb 5, 2025
| yield Failure("unsupported-language", f"Language not supported yet for {self._path}", 0, 0, 1, 1) | ||
| else: | ||
| yield Failure("unknown-language", f"Cannot detect language for {self._path}", 0, 0, 1, 1) | ||
| source_container = self._dependency.load(self._path_lookup) |
There was a problem hiding this comment.
All that logic in the code before these changes is now part of the dependency loading
JCZuurmond
temporarily deployed
to
account-admin
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Let
LocalFileLinterreuse theDependencyinstead falling back on its path as this introduce duplicate ways of loading files.Linked issues
Progresses #3514
Breaks up #3520
Stacked on:
FileLoader#3640LanguageonLocalFile, notCellLanguage#3639LinterContextand access it from the context #3638Functionality
databricks labs ucx migrate-local-codeTests