Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows providers with ROLE_MEMBER "Member Only" role to retrieve non-findable DOIs at /dois endpoint #1317

Merged
merged 4 commits into from
Jan 21, 2025

Conversation

codycooperross
Copy link
Contributor

Purpose

Providers with the ROLE_MEMBER role should have access to non-findable DOIs at the /dois endpoint alongside other authenticated members. This PR addresses this inconsistency.

closes: Add github issue that originated this PR

Approach

Open Questions and Pre-Merge TODOs

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@codycooperross codycooperross requested review from a team and removed request for a team January 16, 2025 20:40
@codycooperross codycooperross requested a review from a team January 17, 2025 16:51
@codycooperross codycooperross requested a review from a team January 21, 2025 15:56
@codycooperross codycooperross merged commit f156484 into master Jan 21, 2025
19 checks passed
@codycooperross codycooperross deleted the role-member-fix branch January 21, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants