Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docs): Add live secret reload docs to k8s remote executor page #12541

Merged
merged 1 commit into from
Feb 7, 2025
Merged

feat(docs): Add live secret reload docs to k8s remote executor page #12541

merged 1 commit into from
Feb 7, 2025

Conversation

pedro93
Copy link
Collaborator

@pedro93 pedro93 commented Feb 3, 2025

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@pedro93 pedro93 changed the title feat(docs): Add live secret reload steps to k8s remote executor feat(docs): Add live secret reload docs to k8s remote executor page Feb 3, 2025
@pedro93 pedro93 requested a review from noggi February 3, 2025 17:23
@github-actions github-actions bot added the docs Issues and Improvements to docs label Feb 3, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Feb 3, 2025
skrydal
skrydal approved these changes Feb 6, 2025
View reviewed changes
Copy link
Collaborator

@skrydal skrydal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Feb 6, 2025
@anshbansal anshbansal merged commit 140b71f into master Feb 7, 2025
80 of 83 checks passed
@anshbansal anshbansal deleted the pedro93-patch-1 branch February 7, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skrydal skrydal skrydal approved these changes

@noggi noggi Awaiting requested review from noggi

Assignees
No one assigned
Labels
docs Issues and Improvements to docs pending-submitter-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pedro93 @skrydal @anshbansal