Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autocomplete): fix autocomplete duplicate field #12558

Merged

Conversation

david-leifker
Copy link
Collaborator

  • refactor to base class
  • prevent duplicate field names

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX devops PR or Issue related to DataHub backend & deployment labels Feb 5, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Feb 5, 2025
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 97.29730% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...lasticsearch/query/request/BaseRequestHandler.java 95.65% 0 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ
...tadata/search/elasticsearch/query/ESBrowseDAO.java 64.88% <ø> (+0.09%) ⬆️
...tadata/search/elasticsearch/query/ESSearchDAO.java 69.45% <ø> (-0.34%) ⬇️
...arch/query/request/AutocompleteRequestHandler.java 95.41% <100.00%> (-0.39%) ⬇️
...sticsearch/query/request/SearchRequestHandler.java 85.06% <100.00%> (-0.74%) ⬇️
...lasticsearch/query/request/BaseRequestHandler.java 95.65% <95.65%> (ø)

... and 100 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65376ee...b8dabcb. Read the comment docs.

* refactor to base class
* prevent duplicate field names
@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Feb 5, 2025
@david-leifker
Copy link
Collaborator Author

cypress tests pass locally, pytest for versioning is not reliable

@david-leifker david-leifker merged commit 52f71dd into datahub-project:master Feb 6, 2025
159 of 163 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops PR or Issue related to DataHub backend & deployment pending-submitter-merge product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants