Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change IMessageReader to use ref instead of out #25

Merged
merged 1 commit into from
Jan 3, 2020
Merged

Change IMessageReader to use ref instead of out #25

merged 1 commit into from
Jan 3, 2020

Conversation

davidfowl
Copy link
Owner

  • The cursors only need to be set if data was consumed.

PS: I'm not 100% sure if being less strict about this is good but it removes some boilerplate.

@davidfowl
Change IMessageReader to use ref instead of out
d62edc5 
- The cursors only need to be set if the return value is true.
@davidfowl davidfowl merged commit 2c17c11 into master Jan 3, 2020
@davidfowl davidfowl deleted the davidfowl/ref-message-reader branch January 15, 2020 04:10
@YairHalberstadt YairHalberstadt mentioned this pull request Jan 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@davidfowl