Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In these changes I've:
ProtocolReaderBenchmarks
ProtocolReader.ReadAsync
can just return immediately).ReadAsync
method must go round again.The ProtocolReader benchmarks do the absolute bare minimum of message reading work with a local
IMessageReader
implementation that just moves the positions along and returns whether the whole expected size is available.Fixes #23.
Local Results: