Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locking rspec and grpc dependencies. Specs will need to be updated to… #113

Merged
merged 1 commit into from
May 3, 2018

Conversation

davissp14
Copy link
Owner

… support newer versions

@codecov
Copy link

codecov bot commented May 3, 2018

Codecov Report

Merging #113 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #113   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           7      7           
  Lines         586    586           
=====================================
  Hits          586    586

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b559a4a...c91fc37. Read the comment docs.

@davissp14 davissp14 merged commit bda7406 into master May 3, 2018
@davissp14 davissp14 deleted the lock-dependencies branch May 3, 2018 22:14
@mgates
Copy link
Contributor

mgates commented May 7, 2018

Do you have any pointers to what the problem is? We're using a more recent grpc version in our app. We might be able to tackle this.

@mgates
Copy link
Contributor

mgates commented May 8, 2018

This is fixed by #115

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants