Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code coverage #119

Merged
merged 1 commit into from
Jun 4, 2018
Merged

Fix code coverage #119

merged 1 commit into from
Jun 4, 2018

Conversation

scalm
Copy link
Contributor

@scalm scalm commented Jun 1, 2018

The code coverage is now broken. This shows only the coverage for the specs.

https://github.com/colszowka/simplecov
SimpleCov Getting Started:

Note: If SimpleCov starts after your application code is already loaded (via require), it won't be able to track your files and their coverage! The SimpleCov.start must be issued before any of your application code is required!

I moved the lines above so that the 'lib' directory also got covered

@codecov
Copy link

codecov bot commented Jun 1, 2018

Codecov Report

Merging #119 into master will decrease coverage by 1.64%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #119      +/-   ##
==========================================
- Coverage     100%   98.35%   -1.65%     
==========================================
  Files           7       24      +17     
  Lines         602     1521     +919     
==========================================
+ Hits          602     1496     +894     
- Misses          0       25      +25
Impacted Files Coverage Δ
lib/etcdv3/etcdrpc/kv_pb.rb 100% <0%> (ø)
lib/etcdv3/connection_wrapper.rb 93.75% <0%> (ø)
lib/etcdv3/kv/requests.rb 100% <0%> (ø)
lib/etcdv3/etcdrpc/auth_pb.rb 100% <0%> (ø)
lib/etcdv3/lease.rb 100% <0%> (ø)
lib/etcdv3/maintenance.rb 100% <0%> (ø)
lib/etcdv3/etcdrpc/rpc_services_pb.rb 100% <0%> (ø)
lib/etcdv3/connection.rb 91.3% <0%> (ø)
lib/etcdv3/etcdrpc/rpc_pb.rb 100% <0%> (ø)
spec/helpers/connections.rb 93.75% <0%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1530e18...e35a461. Read the comment docs.

@davissp14
Copy link
Owner

Thanks!

@davissp14 davissp14 merged commit 5b4373d into davissp14:master Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants