Refine rspec test syntax. Convert css to scss.

app/views/layouts/_header.html.erb

@@ -1,9 +1,10 @@
 <header>
-	<%= image_tag("logo.png", alt: "Sample App", class: "round") %>
+	<% logo = image_tag("logo.png", alt: "Sample App", class: "round") %>
+	<%= link_to logo, root_path %>
 	<nav class="round">
 		<ul>
-			<li><%= link_to "Home", '#' %></li>
-			<li><%= link_to "Help", '#' %></li>
+			<li><%= link_to "Home", root_path %></li>
+			<li><%= link_to "Help", page_path('help') %></li>
 			<li><%= link_to "Sign In", '#' %></li>
 		</ul>
 	</nav>

spec/requests/static_pages_spec.rb

@@ -2,54 +2,33 @@
 
 describe "Static pages" do
 
-  let(:base_title) { "Ruby on Rails Tutorial Sample App" }
+  subject { page }
 
   describe "Home page" do
-    it "should have the content 'Sample App'" do
-    	visit root_path
-    	page.should have_selector('h1', :text=>'Sample App')
-    end
-    it "should have the right title" do
-	  	visit root_path
-	  	page.should have_selector('title',
-	  			:text => "#{base_title} | Home")
-	  end
+    before { visit root_path }
+
+    it { should have_selector('h1', text:'Sample App') }
+    it { should have_selector('title', text: full_title('Home')) }
   end
 
   describe "Help page" do
-  	it "should have the content 'Help'" do
-  		visit page_path('help')
-  		page.should have_selector('h1', :text=>'Help')
-  	end
-  	it "should have the right title" do
-	  	visit page_path('help')
-	  	page.should have_selector('title',
-	  			:text => "#{base_title} | Help")
-	  end
-  end
+    before { visit page_path('help') }
+
+  	it { should have_selector('h1', text: 'Help') }
+  	it { should have_selector('title', text: full_title('Help')) }
+	end
 
   describe "About page" do
-  	it "should have the content 'About'" do
-  		visit page_path('about')
-  		page.should have_selector('h1', :text => 'About')
-  	end
-  	it "should have the right title" do
-	  	visit page_path('about')
-	  	page.should have_selector('title',
-	  			:text => "#{base_title} | About")
-	  end
+    before { visit page_path('about') }
+
+  	it { should have_selector('h1', text: 'About') }
+  	it { should have_selector('title', text: full_title('About')) }
   end
 
   describe "Contact page" do
-    it "should have the h1 'Contact'" do
-      visit page_path('contact')
-      page.should have_selector('h1', text: 'Contact')
-    end
-
-    it "should have the title 'Contact'" do
-      visit page_path('contact')
-      page.should have_selector('title',
-          text: "Ruby on Rails Tutorial Sample App | Contact")
-    end
+    before { visit page_path('contact') }
+
+    it { should have_selector('h1', text: 'Contact') }
+    it { should have_selector('title', text: full_title('Contact')) }
   end
 end

spec/support/utilities.rb

@@ -0,0 +1,8 @@
+def full_title(page_title)
+	base_title = "Ruby on Rails Tutorial Sample App"
+	if page_title.empty?
+		base_title
+	else
+		"#{base_title} | #{page_title}"
+	end
+end