Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add complete app example of lwt_reporter with library #46

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rbjorklin
Copy link

This provides a complete example of an app with library that uses logs. Fixes #45

I know you don't personally use dune but I hope it is okay to include dune files in the example as it is widely used within the community.

@rbjorklin rbjorklin force-pushed the add-lwt-logs-example-app branch from f5b6dbf to 4e5352b Compare September 13, 2022 03:58
@dbuenzli
Copy link
Owner

Thanks for this. I will have a look and integrate it differently when I get some time.

I rather have that in the docs like is done in brr. So that people can read that from odig or ocaml.org rather than having to hunt for the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example is too complex and not complete with regard to dependencies
2 participants