sets binary, parity, and DTR handling for COM ports

dcuddeback · Jul 2, 2017 · 9e00adf · 9e00adf
1 parent cd79200
commit 9e00adf
Showing 1 changed file with 15 additions and 3 deletions.
diff --git a/serial-windows/src/com.rs b/serial-windows/src/com.rs
@@ -143,7 +143,12 @@ impl SerialDevice for COMPort {
 
         match unsafe { GetCommState(self.handle, &mut dcb) } {
             0 => Err(error::last_os_error()),
-            _ => Ok(COMSettings { inner: dcb }),
+            _ => {
+                dcb.fBits |= fBinary;
+                dcb.fBits &= fDtrControl;
+
+                Ok(COMSettings { inner: dcb })
+            }
 
         }
     }
@@ -306,22 +311,29 @@ impl SerialPortSettings for COMSettings {
             core::Bits6 => 6,
             core::Bits7 => 7,
             core::Bits8 => 8,
-        }
+        };
     }
 
     fn set_parity(&mut self, parity: core::Parity) {
         self.inner.Parity = match parity {
             core::ParityNone => NOPARITY,
             core::ParityOdd  => ODDPARITY,
             core::ParityEven => EVENPARITY,
+        };
+
+        if parity == core::ParityNone {
+            self.inner.fBits &= !fParity;
+        }
+        else {
+            self.inner.fBits |= fParity;
         }
     }
 
     fn set_stop_bits(&mut self, stop_bits: core::StopBits) {
         self.inner.StopBits = match stop_bits {
             core::Stop1 => ONESTOPBIT,
             core::Stop2 => TWOSTOPBITS,
-        }
+        };
     }
 
     fn set_flow_control(&mut self, flow_control: core::FlowControl) {