Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kubevirt): add patch get-applied-checksum #743

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

yaroslavborbat
Copy link
Member

@yaroslavborbat yaroslavborbat commented Feb 13, 2025

Description

This patch introduces the GetAppliedChecksum() method in virt-launcher.

virt-handler now tracks synchronized VMIs and computes their checksums. Periodically, it queries virt-launcher for the applied checksum. This ensures that we have two checksums:

The last one sent for synchronization.
The one actually applied.
Storing these checksums in VMI annotations helps verify that spec changes were pushed by virt-handler and not by an attacker.

Why do we need it, and what problem does it solve?

What is the expected result?

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section:  feat
type: core
summary: virt-handler now tracks synchronized VMIs and computes their checksums. Periodically, it queries virt-launcher for the applied checksum. This ensures that we have two checksums:

 

@yaroslavborbat yaroslavborbat added this to the v0.17.0 milestone Feb 13, 2025
@yaroslavborbat yaroslavborbat changed the title add feat(kubevirt): add patch get-applied-checksum Feb 13, 2025
@yaroslavborbat yaroslavborbat force-pushed the feat/kubevirt/patch-get-applied-checksum branch 2 times, most recently from bf253c2 to 765a6ad Compare February 18, 2025 19:02
Signed-off-by: Yaroslav Borbat <[email protected]>
Signed-off-by: Yaroslav Borbat <[email protected]>
Signed-off-by: Yaroslav Borbat <[email protected]>
Signed-off-by: Yaroslav Borbat <[email protected]>
Signed-off-by: Yaroslav Borbat <[email protected]>
Signed-off-by: Yaroslav Borbat <[email protected]>
Signed-off-by: Yaroslav Borbat <[email protected]>
Signed-off-by: Yaroslav Borbat <[email protected]>
Signed-off-by: Yaroslav Borbat <[email protected]>
@yaroslavborbat yaroslavborbat force-pushed the feat/kubevirt/patch-get-applied-checksum branch from 765a6ad to 79c11ad Compare February 20, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant