Skip to content

Commit d8344cf

Browse files
committed
[#V1] Updating method calls to match standardized naming
Updates method names to consistent conventions: - Replaces 'clear' with 'delete!' across multiple Redis type methods - Changes 'delete' to 'remove' in certain context - Updates 'load' to 'from_redis' in hashkey values method Improves method naming consistency and readability
1 parent 38176a8 commit d8344cf

11 files changed

+16
-16
lines changed

lib/familia/redistype/types/hashkey.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ def keys
4747
end
4848

4949
def values
50-
redis.hvals(rediskey).map { |v| load v }
50+
redis.hvals(rediskey).map { |v| from_redis v }
5151
end
5252

5353
def hgetall

try/20_redis_type_try.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@
4646
##=> "v1:limiter:requests:counter:1302468600"
4747

4848
## Increment counter
49-
@limiter1.counter.clear
49+
@limiter1.counter.delete!
5050
@limiter1.counter.increment
5151
#=> 1
5252

try/21_redis_type_zset_try.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -65,4 +65,4 @@
6565
@a.metrics.members
6666
#=> ['metric2']
6767

68-
@a.metrics.clear
68+
@a.metrics.delete!

try/22_redis_type_set_try.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,4 +31,4 @@
3131
#=> 3
3232

3333

34-
@a.tags.clear
34+
@a.tags.delete!

try/23_redis_type_list_try.rb

+2-2
Original file line numberDiff line numberDiff line change
@@ -31,11 +31,11 @@
3131
#=> ['value1','value2','value3']
3232

3333
## Familia::List#delete
34-
@a.owners.delete 'value3'
34+
@a.owners.remove 'value3'
3535
#=> 1
3636

3737
## Familia::List#size
3838
@a.owners.size
3939
#=> 2
4040

41-
@a.owners.clear
41+
@a.owners.delete!

try/24_redis_type_string_try.rb

+2-2
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
#=> 'DECENT!'
2323

2424
## Familia::String#destroy!
25-
@a.value.clear
25+
@a.value.delete!
2626
#=> 1
2727

2828
## Familia::String.new
@@ -63,4 +63,4 @@
6363
#=> '1050bytes'
6464

6565

66-
@ret.clear
66+
@ret.delete!

try/25_redis_type_hash_try.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -50,4 +50,4 @@
5050
#=> ['1', '40', '3']
5151

5252

53-
@a.props.clear
53+
@a.props.delete!

try/26_redis_bool_try.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -39,5 +39,5 @@
3939
#=> "true"
4040

4141
## Clear the hash key
42-
@hashkey.clear
42+
@hashkey.delete!
4343
#=> 1

try/27_redis_horreum_try.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
#=> @identifier
3737

3838
## Remove the key
39-
@hashkey.clear
39+
@hashkey.delete!
4040
#=> 1
4141

4242
## Horreum objects can update and save their fields (1 of 2)

try/30_familia_object_try.rb

+2-2
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@
6868
#=> 3
6969

7070
## Familia class clear
71-
Customer.customers.clear
71+
Customer.customers.delete!
7272
#=> 1
7373

7474
## Familia class replace 1 of 4
@@ -89,4 +89,4 @@
8989

9090

9191
# Teardown
92-
Customer.values.clear
92+
Customer.values.delete!

try/40_customer_try.rb

+3-3
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
#=> "premium"
4040

4141
## Customer can increment secrets_created counter
42-
@customer.secrets_created.clear
42+
@customer.secrets_created.delete!
4343
@customer.secrets_created.increment
4444
@customer.secrets_created.value
4545
#=> '1'
@@ -74,7 +74,7 @@
7474
#=> true
7575

7676
## Customer can be removed from class-level sorted set
77-
Customer.instances.delete(@customer)
77+
Customer.instances.remove(@customer)
7878
Customer.instances.member?(@customer)
7979
#=> false
8080

@@ -137,4 +137,4 @@
137137

138138

139139
# Teardown
140-
Customer.instances.clear
140+
Customer.instances.delete!

0 commit comments

Comments
 (0)