fix: correctly resolve doc URLs for links with child elements (#473)

deneb-viz · Aug 1, 2024 · 633bc22 · 633bc22
1 parent 032a36a
commit 633bc22
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/src/features/json-editor/components/json-editor.tsx b/src/features/json-editor/components/json-editor.tsx
@@ -245,13 +245,13 @@ const getDefaultValue = (role: TEditorRole) => {
  * host.
  */
 const onLinkClick = (e: MouseEvent) => {
-    if (
-        e.target instanceof HTMLAnchorElement &&
-        e.target.getAttribute('data-href')
-    ) {
+    const url = (e.target as HTMLElement)
+        .closest('a')
+        ?.getAttribute('data-href');
+    if (url) {
         e.preventDefault();
         e.stopPropagation();
-        launchUrl(e.target.getAttribute('data-href'));
+        launchUrl(url);
     }
 };