feat(DqElement): deprecate fromFrame function #4881
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbjorge
previously requested changes
Sep 16, 2025
straker
added a commit
that referenced
this pull request
Sep 17, 2025
This test in firefox started to fail all of a sudden, and [almost consistently](#4881). I couldn't figure out why the test kept failing, so after playing around with the order of operations I figured out that the iframe is loading axe and calling the `axe-loaded` event [_before_ mocha runs the `before`](https://app.circleci.com/pipelines/github/dequelabs/axe-core/7369/workflows/8fa125f3-2a32-43d9-8ec9-d5a9ccd172df/jobs/79258?invite=true#step-109-11841_78) where we look for the event. So to fix it I changed up the loading order so the script runs first and adds the event tracking, and now the event tracking now happens outside the `before` function and keeps track of the logs. Then inside the `before` we see if the message has already been fired, otherwise we listen to the event as we were doing before.
straker
force-pushed
the
deprecate-from-frame
branch
2 times, most recently
from
224b180 to
c3b5912
Compare
stephenmathieson
approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function is no longer used in the code base and was replaced in #4093
Closes: #4129