-
Notifications
You must be signed in to change notification settings - Fork 12
feat: Add pubsub notifications #289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
d7cdec5
to
fc728e1
Compare
ff14335
to
9c91ac8
Compare
7f0c7a2
to
68843e0
Compare
68843e0
to
f32f782
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the changes recommended by me. The need for a KSVC
is not clear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you need a knative service ? Generation of events does not need knative-serving.
database: eoapi | ||
username: eoapi | ||
channel: pgstac_items_change | ||
outputs: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would change this to something like:
outputs:
- type: cloudevents
config:
source: /eoapi/pgstac
event_type: org.eoapi.stac.item
destination:
ref:
apiVersion: messaging.knative.dev/v1
kind: Broker
name: my-channel-1
namespace: serverless
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ideea is that when you create a SinkBinding
in your helm chart it will result in a fully qualified URL to the Broker/Channel/Service, whatever else is referenced in the ref
specification.
Also, besides ref
I would also add url
which should be mutually exclusive with ref. In case it is set it should be an URL to which you can POST
the CloudEvent.
Related to: EOEPCA/resource-discovery#167