Skip to content

Commit

Permalink
fix: app best practices
Browse files Browse the repository at this point in the history
  • Loading branch information
devshinthant committed Jul 13, 2024
1 parent 3b529f9 commit ad0b3a0
Show file tree
Hide file tree
Showing 6 changed files with 2 additions and 9 deletions.
2 changes: 1 addition & 1 deletion components/BlogCard.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ export default function BlogCard({ item }: Props) {
priority
width={140}
height={120}
className="h-full md:h-[120px] w-full md:w-[140px] transition-all group-hover:contrast-125 rounded-md"
className="h-full md:h-full bg-contain w-full md:w-[200px] transition-all group-hover:contrast-125 rounded-md"
src={item.image}
alt={item.title}
/>
Expand Down
9 changes: 1 addition & 8 deletions components/sections/ProjectSection.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
import { useEffect, useRef } from "react"
import useOnScreen from "@/hooks/useOnScreen"
import useScrollActive from "@/hooks/useScrollActive"
import Background from "@/public/assets/backgrounds/project-bg.webp"
import ComingSoon from "@/public/assets/projects/coming-soon.png"
import Ecommerce from "@/public/assets/projects/ecommerce.png"
import GuessMyNumber from "@/public/assets/projects/guess-my-number.png"
Expand All @@ -13,7 +12,7 @@ import VSCode from "@/public/assets/projects/vscode.png"
import { useSectionStore } from "@/store/section"
import { gsap } from "gsap"
import { ScrollTrigger } from "gsap/dist/ScrollTrigger"
import Image, { StaticImageData } from "next/image"
import { StaticImageData } from "next/image"
import { RoughNotation } from "react-rough-notation"
import ProjectCard from "../ProjectCard"

Expand Down Expand Up @@ -61,12 +60,6 @@ export default function ProjectSection() {
id="project"
className="relative h-full bg-white overflow-hidden py-14 px-10 lg:px-[5%]"
>
<Image
src={Background}
alt="project-section-background"
className="w-full top-0 h-full absolute left-1/2 -translate-x-1/2 overflow-hidden pointer-events-none select-none"
/>

<div className="w-full max-w-[1100px] h-full m-auto flex flex-col items-center gap-14">
<div className="w-[80%] md:w-full flex absolute left-1/2 -translate-x-1/2 flex-col gap-8 items-center">
<RoughNotation
Expand Down
Binary file removed public/assets/backgrounds/project-bg.webp
Binary file not shown.
Binary file modified public/assets/blog/coming-soon-1.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified public/assets/blog/coming-soon-2.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified public/assets/blog/space-cat.webp
Binary file not shown.

0 comments on commit ad0b3a0

Please sign in to comment.