Skip to content

Commit

Permalink
Clean up amp-inabox feature flag. (ampproject#7606)
Browse files Browse the repository at this point in the history
* Clean up amp-inabox feature flag.

* add back config.
  • Loading branch information
lannka authored Feb 24, 2017
1 parent bcff3e2 commit 6daa5d5
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 13 deletions.
11 changes: 4 additions & 7 deletions src/inabox/amp-inabox.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ import {
import {cssText} from '../../build/css';
import {maybeValidate} from '../validator-integration';
import {maybeTrackImpression} from '../impression';
import {isExperimentOn} from '../experiments';
import {installViewerServiceForDoc} from '../service/viewer-impl';
import {installInaboxViewportService} from './inabox-viewport';
import {installAnchorClickInterceptor} from '../anchor-click-interceptor';
Expand Down Expand Up @@ -78,12 +77,10 @@ startupChunk(self.document, function initial() {
installRuntimeServices(self);
fontStylesheetTimeout(self);

if (isExperimentOn(self, 'amp-inabox')) {
// Install inabox specific Viewport service before
// runtime tries to install the normal one.
installViewerServiceForDoc(ampdoc);
installInaboxViewportService(ampdoc);
}
// Install inabox specific Viewport service before
// runtime tries to install the normal one.
installViewerServiceForDoc(ampdoc);
installInaboxViewportService(ampdoc);

installAmpdocServices(ampdoc);
// We need the core services (viewer/resources) to start instrumenting
Expand Down
6 changes: 0 additions & 6 deletions tools/experiments/experiments.js
Original file line number Diff line number Diff line change
Expand Up @@ -92,12 +92,6 @@ const EXPERIMENTS = [
spec: 'https://github.com/ampproject/amphtml/issues/6196',
cleanupIssue: 'https://github.com/ampproject/amphtml/issues/6217',
},
{
id: 'amp-inabox',
name: 'AMP inabox',
spec: 'https://github.com/ampproject/amphtml/issues/5700',
cleanupIssue: 'https://github.com/ampproject/amphtml/issues/6156',
},
{
id: 'amp-form-var-sub',
name: 'Variable Substitutions in AMP Form inputs for POST/GET submits',
Expand Down

0 comments on commit 6daa5d5

Please sign in to comment.