Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preparations for Fast Convolution Filtering #1 #1903

Merged
merged 1 commit into from
Feb 26, 2021

Conversation

DD4WH
Copy link
Contributor

@DD4WH DD4WH commented Feb 25, 2021

1st preps, not functional

@@ -921,7 +904,7 @@ void AudioDriver_RxProcessorConvolution(AudioSample_t * const src, AudioSample_t

// interpolation

// TODO: at this point we have 128 real audio samples filtered and AGC�ed in the variable (for mono modes)
// TODO: at this point we have 128 real audio samples filtered and AGC�ed in the variable (for mono modes)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible that you use a character set which is not UTF-8? Here it is only a simple character - may grow intensively at other files. Please check.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strange, this question mark character has been in the code for at least 3 years and I did not change it.
My settings were and are "UTF-8"
Which action should I take now?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange indeed! I will merge it - it is not problematic at all. Does Eclipse support charecter set checking? We should check that some time - not important now. I only wanted to put your focus on your encoding settings if they are right.

@df8oe df8oe merged commit 635cc6c into df8oe:directsampling-dev Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants