test: add ic-ref tests and universal canister wasm #5
Conversation
hansl
changed the title
|
This is a huge change already, so instead of making it larger I'm going to do an early review. It is still supporting version 0.8 of the ic-ref, and I'll move to 0.9 as soon as this is in. The Most lines are either just tests that pass and are copied from the ic-ref repo (from Haskell). |
| You will also need a canister to install and run. Unfortunately, at this moment the "universal | ||
| canister" isn't made public and you will want to skip those tests if you can't build it. The | ||
| environment variable to use it is `IC_UNIVERSAL_CANISTER_PATH` and it should point to the | ||
| WASM file on disk. |
There was a problem hiding this comment.
@hansl, I’d advise you to just copy https://github.com/dfinity-lab/ic-ref/tree/master/universal-canister/ into this repo. There is nothing secret about it, and it has no stable interface, so it should be tightly coupled to it’s driver. It is not going to go well if you (in here) and @ielashi (in dfinity) continue to use the universal canister as it exists in the ic-ref repo.
Also, many tests that you copied and much functionality of the universal canister are not relevant to test the rust agent (which, I understand, is the purpose here), so you can actually simplify a bit – for the rust agent, you really only need query and update. Or am I missing something?
* tests: add ic-ref tests and universal canister wasm * add wasm32 target to CI * remove warnings
No description provided.