Fix: string columns with dates failed to render.

dieface · May 19, 2015 · 30a89bf · 30a89bf
1 parent 6312f87
commit 30a89bf
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/rd_ui/app/scripts/services/resources.js b/rd_ui/app/scripts/services/resources.js
@@ -12,6 +12,8 @@
 
         var columnTypes = {};
 
+        // TODO: we should stop manipulating incoming data, and switch to relaying on the column type set by the backend.
+        // This logic is prone to errors, and better be removed. Kept for now, for backward compatability.
         _.each(this.query_result.data.rows, function (row) {
           _.each(row, function (v, k) {
             if (angular.isNumber(v)) {
@@ -30,7 +32,7 @@
 
         _.each(this.query_result.data.columns, function(column) {
           if (columnTypes[column.name]) {
-            if (column.type == null) {
+            if (column.type == null || column.type == 'string') {
               column.type = columnTypes[column.name];
             }
           }