Fix some warnings (#349)

CHANGELOG.md

@@ -5,6 +5,7 @@ Changelog
 
 v1.18.1 (??.??.2024)
  * Improve page config setup in backend
+ * Fix PHP warnings
 
 v1.18.0 (09.12.2023)
 

Classes/Database/Connection.php

@@ -2,6 +2,7 @@
 
 namespace Sys25\RnBase\Database;
 
+use Countable;
 use mysqli_result;
 use PDO;
 use Sys25\RnBase\Backend\Utility\TCA;
@@ -148,7 +149,7 @@ public function doSelect($what, $from, $arr, $debug = false)
 
         if ($debug) {
             Debug::debug([
-                'Rows retrieved ' => count($rows),
+                'Rows retrieved ' => $rows instanceof Countable ? $rows->count() : count($rows),
                 'Time ' => (microtime(true) - $time),
                 'Memory consumed ' => (memory_get_usage() - $mem),
                 'QB used' => is_object($queryBuilder),

Classes/Utility/Language.php

@@ -11,7 +11,7 @@
 /***************************************************************
  *  Copyright notice
  *
- *  (c) 2012-2023 Rene Nitzsche ([email protected])
+ *  (c) 2012-2024 Rene Nitzsche ([email protected])
  *  All rights reserved
  *
  *  This script is part of the TYPO3 project. The TYPO3 project is
@@ -33,6 +33,7 @@
 
 /**
  * Wrapper for language usage.
+ * Muss komplett überarbeitet werden. Da sind viele fragwürdige Dinge enthalten.
  *
  * @author Rene Nitzsche
  */
@@ -185,10 +186,14 @@ protected function loadLLOverlay46($confLL)
                         $this->LOCAL_LANG[$languageKey][$labelKey][0]['target'] = $labelValue;
                         // For labels coming from the TypoScript (database) the charset is assumed to be "forceCharset"
                         // and if that is not set, assumed to be that of the individual system languages
-                        if ($GLOBALS['TYPO3_CONF_VARS']['BE']['forceCharset']) {
+                        if ($GLOBALS['TYPO3_CONF_VARS']['BE']['forceCharset'] ?? false) {
                             $this->LOCAL_LANG_charset[$languageKey][$labelKey] = $GLOBALS['TYPO3_CONF_VARS']['BE']['forceCharset'];
                         } else {
-                            $this->LOCAL_LANG_charset[$languageKey][$labelKey] = $GLOBALS['TSFE']->csConvObj->charSetArray[$languageKey];
+                            // FIXME: verhindert zunächst nur Warnungen. Muss aber eh komplett überarbeitet werden
+                            $csConvObj = $GLOBALS['TSFE']->csConvObj;
+                            if ($csConvObj && isset($csConvObj->charSetArray[$languageKey])) {
+                                $this->LOCAL_LANG_charset[$languageKey][$labelKey] = $csConvObj->charSetArray[$languageKey];
+                            }
                         }
                     }
                 }

Classes/Utility/TSFAL.php

@@ -22,7 +22,7 @@
 /***************************************************************
  *  Copyright notice
  *
- *  (c) 2013-2023 Rene Nitzsche
+ *  (c) 2013-2024 Rene Nitzsche
  *  Contact: [email protected]
  *  All rights reserved
  *
@@ -323,10 +323,10 @@ public function fetchFirstReference($content, $configuration)
     {
         $contentObject = $this->cObj;
 
-        if ($configuration['refUid'] || $configuration['refUid.']) {
-            $uid = intval($contentObject->stdWrap($configuration['refUid'], $configuration['refUid.']));
+        if (isset($configuration['refUid']) || isset($configuration['refUid.'])) {
+            $uid = intval($contentObject->stdWrap($configuration['refUid'] ?? '', $configuration['refUid.'] ?? []));
         } else {
-            $uid = $contentObject->data['_LOCALIZED_UID'] ? $contentObject->data['_LOCALIZED_UID'] : $contentObject->data['uid'];
+            $uid = $contentObject->data['_LOCALIZED_UID'] ?? $contentObject->data['uid'];
         }
         $refTable = ($configuration['refTable'] && is_array($GLOBALS['TCA'][$configuration['refTable']])) ?
                     $configuration['refTable'] : 'tt_content';