Skip to content

Conversation

motatoes
Copy link
Contributor

No description provided.

@motatoes motatoes changed the title titles wip: state management docs Sep 18, 2025
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Summary

This PR creates a skeleton structure for state management documentation by adding 8 new MDX files and updating the documentation navigation structure. All files currently contain only front matter with titles and no content, which is consistent with the "wip" (work in progress) designation in the PR title.

Major Changes

  • Added 8 new state management documentation files: introduction, quickstart, architecture, SSO configuration, CI integration, API reference, CLI reference, and development guide
  • Updated mint.json to include new "State Management" section in documentation navigation
  • Removed one line from go.work.sum (likely due to dependency cleanup)

Issues Found

  • Title capitalization inconsistencies (Api/CLI should be API/CLI)
  • Navigation section titled "Stage Management" instead of "State Management"
  • All MDX files missing trailing newlines

Confidence score: 4/5

  • This PR is safe to merge with minimal risk as it only adds documentation structure without affecting functionality
  • High confidence due to the non-functional nature of the changes. Only minor formatting and consistency issues identified that don't affect the build or runtime behavior. The WIP nature is clearly indicated in the PR title.
  • The mint.json file needs the title correction from "Stage Management" to "State Management"

10 files reviewed, 4 comments

Edit Code Review Bot Settings | Greptile

docs/mint.json Outdated
]
},
{
"group": "Stage Management",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

syntax: Group title mismatch - JSON shows "Stage Management" but it should be "State Management" based on the folder name and page titles

@@ -0,0 +1,3 @@
---
title: "Api Reference"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Title inconsistency - should be "API Reference" (standard capitalization)

@@ -0,0 +1,3 @@
---
title: "Cli Reference"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Title inconsistency - should be "CLI Reference" (standard capitalization)

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Summary

This PR adds initial state management documentation structure to the Digger project. The changes include creating stub files for various state management topics like architecture, quickstart, SSO configuration, and CLI/API references. The main content is in the introduction file, which explains the challenges with S3-based state management and introduces Digger's self-hostable state manager solution.

Key changes:

  • Added new "State Management" section to docs/mint.json navigation
  • Created 8 new MDX documentation files (most are stubs with only titles)
  • Added comprehensive introduction explaining state management benefits and features
  • Included comparison table of S3 drawbacks vs. state manager solutions

Minor issues found include typos ("convinient"), grammar errors ("integratable"), and an incomplete sentence at the end of the introduction.

Confidence score: 4/5

  • This PR is safe to merge with minimal risk as it only adds documentation files
  • Score reflects that this is purely documentation with minor typos and grammar issues that need fixing, but no functional code changes
  • Pay attention to docs/ce/state-management/introduction.mdx for the spelling and grammar corrections

3 files reviewed, 4 comments

Edit Code Review Bot Settings | Greptile

---

By default digger does not take any opinions on how to manage state. Most users of digger bring their own
state management such as an S3 bucket and use digger for the PR automation layer. This can be convinient but
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

syntax: Typo: "convinient" should be "convenient"

Suggested change
state management such as an S3 bucket and use digger for the PR automation layer. This can be convinient but
state management such as an S3 bucket and use digger for the PR automation layer. This can be convenient but

it does not come without challenges:

- Harder to secure access to the bucket in a team setting
- cross-account state access becomes tricky
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Capitalization inconsistency - should start with capital "C"

Suggested change
- cross-account state access becomes tricky
- Cross-account state access becomes tricky


| Drawbacks of Using S3 for Terraform State | Mitigations / Best Practices |
|---------------------------------------------------------------|-----------------------------------------------------------------------------------------------------------------------------|
| Harder to secure access to the bucket in a team setting | Using RBAC policies have fine-grained control on who has access to state in the team, integratable with SSO |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

syntax: Grammar issue: "integratable" should be "integrable" or "can be integrated"

Suggested change
| Harder to secure access to the bucket in a team setting | Using RBAC policies have fine-grained control on who has access to state in the team, integratable with SSO |
| Using RBAC policies have fine-grained control on who has access to state in the team, can be integrated with SSO |


The state manager currently supports Amazon S3 as a backend with plans to support GCP buckets, Azure blob storage and more.

Currently the state manager is self-hostable. There is no managed version of the state manager. Although it can be used in conjunction with digger
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

syntax: Sentence is incomplete and ends abruptly

Suggested change
Currently the state manager is self-hostable. There is no managed version of the state manager. Although it can be used in conjunction with digger
Currently the state manager is self-hostable. There is no managed version of the state manager. Although it can be used in conjunction with digger.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Summary

This PR adds a comprehensive quickstart guide for OpenTaco state management along with supporting Docker configuration files. The documentation covers CLI installation, Auth0 setup, Statesman configuration, and Docker deployment.

Key additions:

  • New quickstart guide with step-by-step setup instructions
  • Docker Compose configuration for easy deployment
  • Environment variable examples and templates
  • Health check endpoints and service configuration

Issues found:

  • Hard-coded version references that will become outdated
  • Inconsistent file naming references between documentation and example files
  • Missing cross-platform installation instructions

Confidence score: 4/5

  • This PR is safe to merge with minor maintenance concerns
  • Score reflects well-structured documentation with comprehensive setup instructions, but contains hard-coded version references and filename inconsistencies that should be addressed to prevent future maintenance issues
  • Pay attention to version references in quickstart.mdx and filename consistency between documentation and example files

3 files reviewed, 5 comments

Edit Code Review Bot Settings | Greptile


### On macOS

The first thing you'll want to do is visit our releases page here https://github.com/diggerhq/digger/releases and check the latest taco/cli release. Right now it is v0.1.7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Hard-coded version reference will become outdated quickly

Suggested change
The first thing you'll want to do is visit our releases page here https://github.com/diggerhq/digger/releases and check the latest taco/cli release. Right now it is v0.1.7
The first thing you'll want to do is visit our releases page here https://github.com/diggerhq/digger/releases and check the latest taco/cli release.

We can then do:

```bash
curl -L https://github.com/diggerhq/digger/releases/download/taco/cli/v0.1.7/taco-darwin-arm64 -o taco
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Hard-coded version in URL will break when version changes

Suggested change
curl -L https://github.com/diggerhq/digger/releases/download/taco/cli/v0.1.7/taco-darwin-arm64 -o taco
curl -L https://github.com/diggerhq/digger/releases/latest/download/taco-darwin-arm64 -o taco

image: ${STATESMAN_IMAGE:-ghcr.io/diggerhq/digger/taco-statesman:latest}
ports:
- "${OPENTACO_PORT:-8080}:8080"
env_file:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

syntax: Referencing .env.example but the example file is named config.env

Suggested change
env_file:
- .env # Copy from config.env and customize

ports:
- "${OPENTACO_PORT:-8080}:8080"
env_file:
- .env # Copy from .env.example and customize
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

syntax: Referencing .env.example but the example file is named config.env

Suggested change
- .env # Copy from .env.example and customize
- .env # Copy from config.env and customize


## CLI Install (WIP)

### On macOS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Only covers macOS installation - missing Windows and Linux instructions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants