Skip to content

Commit

Permalink
Minor fix: no more closing channels
Browse files Browse the repository at this point in the history
  • Loading branch information
RadhiFadlillah committed Aug 12, 2019
1 parent bd9d4b1 commit ba4c081
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion pkg/warc/writer.go
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,11 @@ func NewArchive(req ArchivalRequest, dstPath string) error {
ResourceMap: make(map[string]struct{}),
LogEnabled: req.LogEnabled,
}
defer arc.Close()

// TODO: investigate whether the channel must be closed or not.
// At first, I thought the channels must be closed. Unfortunately, it leads to
// a panic when error message is accidentally sent after error channels closed.
// defer arc.Close()

// Process input depending on its type.
// If it's HTML, we need to extract the sub resources that used by it, e.g some CSS or JS files.
Expand Down

0 comments on commit ba4c081

Please sign in to comment.