Maintenance: Clean up unused Checklist code

dineshkummarc · Nov 7, 2024 · 1dcc2a1 · 1dcc2a1
1 parent fbd3890
commit 1dcc2a1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 33 deletions.
diff --git a/app/controllers/tickets_controller.rb b/app/controllers/tickets_controller.rb
@@ -98,6 +98,7 @@ def create
 
       # Prevent direct access to checklist via API
       # Otherwise users may get unauthorized access to checklists of other tickets
+      params.delete(:checklist)
       params.delete(:checklist_id)
 
       clean_params = Ticket.association_name_to_id_convert(params)
@@ -249,6 +250,7 @@ def update
 
     # Prevent direct access to checklist via API
     # Otherwise users may get unauthorized access to checklists of other tickets
+    params.delete(:checklist)
     params.delete(:checklist_id)
 
     clean_params = Ticket.association_name_to_id_convert(params)

diff --git a/app/policies/controllers/ticket_checklist_controller_policy.rb b/app/policies/controllers/ticket_checklist_controller_policy.rb