feat: add internationalization #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mvares
commented
Feb 13, 2025
•
mvares
commented
- Closes Footer - Putting "language & region" selector to work #64
- Closes Header - Putting "language & region" icon selector in the header #128
mvares
changed the title
mvares
changed the title
…for i18n breaking assets
DaniloArantesF
force-pushed
the
feat/integrate-native-internationalization
branch
from
90f66e1 to
b09522b
Compare
|
@mvares @otavioaclima There are still plenty of places where translations are needed and this is not 100% but I'd rather we move on with it as it's a big one with a lot of files moved/changed. We can work to finish replacing english defaults on a second pass. Any objections there? |
|
@DaniloArantesF need to change de texts on the menu bar and header. |
|
@DaniloArantesF |
|
And translate the Footer please @DaniloArantesF . |
DaniloArantesF
approved these changes
Feb 17, 2025
There was a problem hiding this comment.
Looks ok for now. We will improve on this solution, finish tweaking and localizing the website in subsequent PRs. Good work @mvares!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.