feat: pass prepared transaction to the SendConfirmation screen with navigate #102
Conversation
| } | ||
|
|
||
| export function usePrepareSendTransactions( | ||
| existingPrepareTranscation?: UsePrepareSendTransactions |
There was a problem hiding this comment.
i'm imagining how we'd document how to use this variable and it's pretty difficult to explain, and given the niche use case i think it's better not to expose this to builders? wdyt?
There was a problem hiding this comment.
There's no way to call useAsyncCallback optionally as it is a hook so it has to be defined in a declarative manner which means that it will be fired in any case. Unless we prevent it in the actual callback itself, like in this implementation. Or do you mean renaming the variable to just a boolean flag like disabledOnInit?
The other approach could be to wrap the whole SendConfirmation return into a HOC wrapper like <LoadPrepareTransaction> but IMHO this would be more cumbersome and complex.
Or is there any particular approach you were thinking about?
There was a problem hiding this comment.
oh actually this is my bad, i misunderstood this as the exported prepareTransactions that we expose to builders. ignore this comment
| const { | ||
| prepareTransactionsResult, | ||
| refreshPreparedTransactions, | ||
| clearPreparedTransactions, | ||
| prepareTransactionError, | ||
| prepareTransactionLoading, | ||
| } = usePrepareSendTransactions() | ||
| } = prepareTransactions |
There was a problem hiding this comment.
do we need to pass everything to the next screen? we don't allow proceeding unless the transaction is possible, so why not pass only prepareTransactionsResult? we may also want to serialise the prepared transaction (i vaguely remember that is recommended with this navigation lib)
| @@ -29,10 +30,18 @@ type NestedNavigatorParams<ParamList> = { | |||
| : { screen: K; params: ParamList[K] } | |||
| }[keyof ParamList] | |||
|
|
|||
| interface SendConfirmationFromExternalParams { | |||
There was a problem hiding this comment.
this could be simplified to Omit<SendConfirmationParams, 'preparedTransactions'>?
There was a problem hiding this comment.
I did it this way so it would be possible to pass it directly into the hook without checking "prepareTransactions" in props.route.params as otherwise it is not available:
Description
This PR implements passing prepared transaction from
SendEnterAmounttoSendConfirmationwithnavigateto prevent unnecessary call to prepare transaction again. The call still can be called when navigating toSendConfirmationwithScreen.SendConfirmationFromExternal.Test plan
It doesn't load anything and doesn't show loading spinners when navigating to the SendConfirmation
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-02-25.at.17.53.45.mp4
Related issues
Relates to RET-1300
Backwards compatibility
Yes
Network scalability
If a new NetworkId and/or Network are added in the future, the changes in this PR will: