Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SI multilingual #84

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

SI multilingual #84

wants to merge 3 commits into from

Conversation

joancf
Copy link

@joancf joancf commented Dec 11, 2017

It allows to get the description of the synset in a different language
than the one used for disambiguation (the one of the text) useful for
translation or help to understand the text

It allows to get the description of the synset in a different language
than the one used for disambiguation (the one of the text) useful for
translation or help to understand the text
@reckart
Copy link
Member

reckart commented Dec 16, 2017

Jenkins, can you test this please?

@ukp-svc-jenkins
Copy link

Can one of the admins verify this patch?

@reckart
Copy link
Member

reckart commented Dec 16, 2017

Jenkins, can you test this please?

@reckart
Copy link
Member

reckart commented Dec 16, 2017

Thanks for the PR. It took us a while to react since we first looked into fixing the automatic build and enabling our Jenkins to do PR builds.

@logological Jenkins can now build PRs if asked politely to do so ;)

@ukp-svc-jenkins
Copy link

Hmm... room for improvement.
Close, but no cigar.
Looks like there are still a few rough edges...

@reckart
Copy link
Member

reckart commented Dec 16, 2017

Jenkins still needs a bit of fine-tuning, so please excuse issue spam.

Jenkins, can you test this please?

@reckart
Copy link
Member

reckart commented Dec 16, 2017

Hm, looks like this PR is incomplete in the sense that it does not update all relevant modules with the updated signature of the getSenseDescription method. At least it seems the integration build fails for this reason. You can click on the "Details" link next to the "UKP OSS Jenkins" check.

    
    @OverRide
    public String getSenseDescription(String senseId, boolean seclang)
throws SenseInventoryException {
		return getSenseDescription(senseId);
	}
@reckart
Copy link
Member

reckart commented Dec 19, 2017

Jenkins, can you test this please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants