pr: add more items to the checklist

* when submitting code people must be provide unit tests * when submitting code for a new functionnality, integration tests must be added so we can get coverage of that feature in the CI. Signed-off-by: Sébastien Han <[email protected]>
dlambrig · Jul 11, 2019 · 142b2ca · 142b2ca
1 parent a4168fc
commit 142b2ca
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
@@ -8,7 +8,11 @@ Thank you for contributing to Rook! -->
 Resolves #
 
 **Checklist:**
+
+- [ ] Reviewed the developer guide on [Submitting a Pull Request](https://rook.io/docs/rook/v1.0/development-flow.html#submitting-a-pull-request)
 - [ ] Documentation has been updated, if necessary.
+- [ ] Unit tests have been added, if necessary.
+- [ ] Integration tests have been added, if necessary.
 - [ ] Pending release notes updated with breaking and/or notable changes, if necessary.
 - [ ] Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
 - [ ] Code generation (`make codegen`) has been run to update object specifications, if necessary.