Skip to content

[spec/expression] Improve AssignExpression docs for arrays #4236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ntrel
Copy link
Contributor

@ntrel ntrel commented May 3, 2025

Differentiate between a slice expression and assigning to an array.
Rename 'Array Setting' section to 'Array Filling'.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @ntrel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

element type of the left-hand side, then the array contents of the
left-hand side are set to the right-hand side.
element type of the left-hand side, then each element of the slice
expression will be assigned to the value on the right-hand side.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, 'slice expression' is much easier to talk about than a SliceOperation (#3680), as the latter is awkward and not an expression. I prefer it before when we had SliceExpression, which is more natural and consistent with the other docs.

Differentiate between an a slice expression and assigning to an array.
Rename 'Array Setting' to 'Array Filling' and tweak wording.
)

$(LI If the lvalue is an array, the behavior is as described in
$(DDSUBLINK spec/arrays, assignment, Array Assignment).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that link covers static array copying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants