to_binary_s
should always return ASCII-8BIT encoded strings
#120
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StringIO in Ruby <= 2.6.X didn't respect
Encoding.default_internal
, socalling
read
on the StringIO wouldn't tag the string with the sameencoding. Ruby 2.7 fixes this bug. The problem is that
to_binary_s
is returning a binary string and should always return an ASCII-8BIT
encoded string.
This patch changes the method to always return the ASCII-8BIT string
regardless of the value of
Encoding.default_internal
.Here is the behavior of StringIO on Ruby 2.6:
Here it is on 2.7:
We can see 2.7 respects
default_internal
, but unfortunately that meansthat
to_binary_s
would return the wrong encoding.