Skip to content

Commit

Permalink
Fix broken interaction previews in the exploration editor (oppia#6627)
Browse files Browse the repository at this point in the history
* fix imports

* fix import orders

* remove stray comma
  • Loading branch information
nithusha21 authored Apr 24, 2019
1 parent 0fb2544 commit 1afa7a2
Show file tree
Hide file tree
Showing 6 changed files with 20 additions and 24 deletions.
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<script src="/extensions/interactions/DragAndDropSortInput/directives/DragAndDropSortInputRulesService.js"></script>
<script src="/extensions/interactions/DragAndDropSortInput/directives/DragAndDropSortInputValidationService.js"></script>
<script src="/extensions/interactions/DragAndDropSortInput/directives/OppiaInteractiveDragAndDropSortInputDirective.js"></script>
<script src="/extensions/interactions/DragAndDropSortInput/directives/OppiaResponseDragAndDropSortInputDirective.js"></script>
<script src="/extensions/interactions/DragAndDropSortInput/directives/OppiaShortResponseDragAndDropSortInputDirective.js"></script>
<script src="/extensions/interactions/DragAndDropSortInput/directives/DragAndDropSortInputRulesService.js"></script>
<script src="/extensions/interactions/DragAndDropSortInput/directives/DragAndDropSortInputValidationService.js"></script>
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,10 @@
*/

oppia.directive('oppiaInteractiveDragAndDropSortInput', [
'HtmlEscaperService', 'UrlInterpolationService',
'dragAndDropSortInputRulesService',
function(
HtmlEscaperService, UrlInterpolationService,
dragAndDropSortInputRulesService) {
'DragAndDropSortInputRulesService', 'HtmlEscaperService',
'UrlInterpolationService', function(
DragAndDropSortInputRulesService, HtmlEscaperService,
UrlInterpolationService) {
return {
restrict: 'E',
scope: {},
Expand Down
4 changes: 2 additions & 2 deletions extensions/interactions/ImageClickInput/ImageClickInput.html
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<script src="/extensions/interactions/ImageClickInput/directives/ImageClickInputRulesService.js"></script>
<script src="/extensions/interactions/ImageClickInput/directives/ImageClickInputValidationService.js"></script>
<script src="/extensions/interactions/ImageClickInput/directives/OppiaInteractiveImageClickInputDirective.js"></script>
<script src="/extensions/interactions/ImageClickInput/directives/OppiaResponseImageClickInputDirective.js"></script>
<script src="/extensions/interactions/ImageClickInput/directives/OppiaShortResponseImageClickInputDirective.js"></script>
<script src="/extensions/interactions/ImageClickInput/directives/ImageClickInputRulesService.js"></script>
<script src="/extensions/interactions/ImageClickInput/directives/ImageClickInputValidationService.js"></script>
Original file line number Diff line number Diff line change
Expand Up @@ -22,16 +22,14 @@

oppia.directive('oppiaInteractiveImageClickInput', [
'$sce', 'AssetsBackendApiService', 'ContextService',
'HtmlEscaperService', 'ImagePreloaderService',
'UrlInterpolationService', 'imageClickInputRulesService',
'EVENT_NEW_CARD_AVAILABLE', 'EXPLORATION_EDITOR_TAB_CONTEXT',
'LOADING_INDICATOR_URL',
'HtmlEscaperService', 'ImageClickInputRulesService', 'ImagePreloaderService',
'UrlInterpolationService', 'EVENT_NEW_CARD_AVAILABLE',
'EXPLORATION_EDITOR_TAB_CONTEXT', 'LOADING_INDICATOR_URL',
function(
$sce, AssetsBackendApiService, ContextService,
HtmlEscaperService, ImagePreloaderService,
UrlInterpolationService, imageClickInputRulesService,
EVENT_NEW_CARD_AVAILABLE, EXPLORATION_EDITOR_TAB_CONTEXT,
LOADING_INDICATOR_URL) {
HtmlEscaperService, ImageClickInputRulesService, ImagePreloaderService,
UrlInterpolationService, EVENT_NEW_CARD_AVAILABLE,
EXPLORATION_EDITOR_TAB_CONTEXT, LOADING_INDICATOR_URL) {
return {
restrict: 'E',
scope: {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<link rel="stylesheet" type="text/css" href="/extensions/interactions/ItemSelectionInput/static/item_selection_input.css">

<script src="/extensions/interactions/ItemSelectionInput/directives/ItemSelectionInputRulesService.js"></script>
<script src="/extensions/interactions/ItemSelectionInput/directives/ItemSelectionInputValidationService.js"></script>
<script src="/extensions/interactions/ItemSelectionInput/directives/OppiaInteractiveItemSelectionInputDirective.js"></script>
<script src="/extensions/interactions/ItemSelectionInput/directives/OppiaResponseItemSelectionInputDirective.js"></script>
<script src="/extensions/interactions/ItemSelectionInput/directives/OppiaShortResponseItemSelectionInputDirective.js"></script>
<script src="/extensions/interactions/ItemSelectionInput/directives/ItemSelectionInputRulesService.js"></script>
<script src="/extensions/interactions/ItemSelectionInput/directives/ItemSelectionInputValidationService.js"></script>
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,10 @@
*/

oppia.directive('oppiaInteractiveItemSelectionInput', [
'HtmlEscaperService', 'UrlInterpolationService',
'itemSelectionInputRulesService',
function(
HtmlEscaperService, UrlInterpolationService,
itemSelectionInputRulesService) {
'HtmlEscaperService', 'ItemSelectionInputRulesService',
'UrlInterpolationService', function(
HtmlEscaperService, ItemSelectionInputRulesService,
UrlInterpolationService) {
return {
restrict: 'E',
scope: {},
Expand Down

0 comments on commit 1afa7a2

Please sign in to comment.