Addressed code review, only minor changes.

core/controllers/galleries.py

@@ -31,6 +31,7 @@
     models.NAMES.base_model, models.NAMES.exploration])
 current_user_services = models.Registry.import_current_user_services()
 import feconf
+import utils
 
 import jinja2
 
@@ -81,7 +82,10 @@ def _get_short_language_description(self, full_language_description):
     def get(self):
         """Handles GET requests."""
         # TODO(sll): Implement paging.
-        # TODO(msl): Add realtime layer to get up-to-date gallery
+
+        # TODO(sll): Precompute and cache gallery categories. Or have a fixed
+        # list of categories and 'Other', and gradually classify the
+        # explorations in 'Other'.
 
         language_codes_to_short_descs = {
             lc['code']: self._get_short_language_description(lc['description'])
@@ -95,20 +99,23 @@ def get(self):
                 exp_services.get_private_at_least_viewable_exploration_summaries(
                     self.user_id))
 
+        # TODO(msl): Store 'is_editable' in exploration summary to avoid O(n)
+        # individual lookups. Note that this will depend on user_id.
         explorations_list = [{
             'id': exp_summary.id,
             'title': exp_summary.title,
             'category': exp_summary.category,
             'objective': exp_summary.objective,
             'language': language_codes_to_short_descs.get(
                 exp_summary.language_code, exp_summary.language_code),
-            'last_updated': exp_summary.last_updated,
+            'last_updated': utils.get_time_in_millisecs(
+                exp_summary.last_updated),
             'status': exp_summary.status,
             'community_owned': exp_summary.community_owned,
             'is_editable': exp_services.exp_summary_is_editable(
                 exp_summary,
                 user_id=self.user_id)
-        } for key, exp_summary in exp_summaries_dict.iteritems()]
+        } for exp_summary in exp_summaries_dict.values()]
 
         if len(explorations_list) == feconf.DEFAULT_QUERY_LIMIT:
             logging.error(

core/domain/exp_domain.py

@@ -1448,7 +1448,6 @@ def is_equal_to(self, other):
 
         for prop in simple_props:
             if getattr(self, prop) != getattr(other, prop):
-                print 'different', prop,  getattr(self, prop), getattr(other, prop)
                 return False
 
         return True

core/domain/exp_jobs.py

@@ -20,9 +20,9 @@
 
 import ast
 
+from core.domain import exp_domain
 import feconf
 from core import jobs
-from core.domain import exp_domain
 from core.platform import models
 (base_models, exp_models,) = models.Registry.import_models([
     models.NAMES.base_model, models.NAMES.exploration])
@@ -38,14 +38,15 @@ class ExpSummaryRealtimeModel(
         jobs.BaseRealtimeDatastoreClassForContinuousComputations):
     pass
 
+
 class ExpSummariesAggregator(jobs.BaseContinuousComputationManager):
     """A continuous-computation job computing summaries of all explorations.
     The summaries store the following information:
 
-        title, category, objective, language_code, skill_tags, 
-        last_updated (as float in milliseconds), created_on (as
-        float in milliseconds), status (private, public or publicized),
-        community_owned, owner_ids, editor_ids, viewer_ids, version.
+        title, category, objective, language_code, skill_tags,
+        last_updated, created_on, status (private, public or
+        publicized), community_owned, owner_ids, editor_ids,
+        viewer_ids, version.
     """
     @classmethod
     def get_event_types_listened_to(cls):
@@ -84,18 +85,14 @@ def map(exploration_model):
         from core.domain import exp_services
         if ExpSummaryMRJobManager._entity_created_before_job_queued(
 				exploration_model):
-            # create exploration summary
             exploration = exp_services.get_exploration_from_model(exploration_model)
             exp_services.create_exploration_summary(exploration)
-            yield (exploration_model.id, None)
 
     @staticmethod
     def reduce(exp_id, list_of_exps):
         pass
 
 
-
-
 class IndexAllExplorationsJobManager(jobs.BaseMapReduceJobManager):
     """Job that indexes all explorations"""
 

core/domain/exp_jobs_for_production_tests.py

@@ -20,14 +20,12 @@
 
 __author__ = 'Marcel Schmittfull'
 
+from core.domain import exp_domain
 import feconf
 from core import jobs
-from core.domain import exp_domain
 from core.platform import models
 (base_models, exp_models,) = models.Registry.import_models([
     models.NAMES.base_model, models.NAMES.exploration])
-#transaction_services = models.Registry.import_transaction_services()
-#import utils
 
 from google.appengine.ext import ndb
 
@@ -36,6 +34,7 @@ class ExpCopiesRealtimeModel(
         jobs.BaseRealtimeDatastoreClassForContinuousComputations):
     ExpCopy = ndb.JsonProperty(repeated=True)
 
+
 class ExpCopiesAggregator(jobs.BaseContinuousComputationManager):
     """A continuous-computation job creating 10 published copies of every
     existing exploration, with the eid being '[old_eid]copy[copy_number]',
@@ -122,6 +121,7 @@ def _get_batch_job_manager_class(cls):
     def _handle_incoming_event(cls, active_realtime_layer, event_type, *args):
         pass
 
+
 class DeleteExpCopiesMRJobManager(
         jobs.BaseMapReduceJobManagerForContinuousComputations):
     """Job that deletes all explorations in category 'Copies'.

core/domain/exp_jobs_test.py

@@ -23,20 +23,20 @@
 import collections
 import datetime
 
+from core import jobs
+from core import jobs_registry
 from core.domain import config_services
 from core.domain import event_services
 from core.domain import exp_domain
 from core.domain import exp_jobs
 from core.domain import exp_services
-import feconf
-from core import jobs
-from core import jobs_registry
+from core.domain import rights_manager
 from core.platform import models
+from core.tests import test_utils
+import feconf
 (job_models, exp_models,) = models.Registry.import_models([
    models.NAMES.job, models.NAMES.exploration])
-from core.domain import rights_manager
 search_services = models.Registry.import_search_services()
-from core.tests import test_utils
 import utils
 
 
@@ -173,7 +173,7 @@ def _run_batch_job_once_and_verify_output(
                 # publish or publicize exploration
                 if spec['status'] == rights_manager.EXPLORATION_STATUS_PUBLIC:
                     rights_manager.publish_exploration(self.owner_id, exp_id)
-                if spec['status'] == rights_manager.EXPLORATION_STATUS_PUBLICIZED:
+                elif spec['status'] == rights_manager.EXPLORATION_STATUS_PUBLICIZED:
                     rights_manager.publish_exploration(self.owner_id, exp_id)
                     rights_manager.publicize_exploration(self.owner_id, exp_id)
 
@@ -187,13 +187,11 @@ def _run_batch_job_once_and_verify_output(
 
                 last_updated = None
                 if exploration.last_updated:
-                    last_updated = utils.get_time_in_millisecs(
-                        exploration.last_updated)
+                    last_updated = exploration.last_updated
 
                 created_on = None
                 if exploration.created_on:
-                    created_on = utils.get_time_in_millisecs(
-                        exploration.created_on)
+                    created_on = exploration.created_on
 
                 # manually create the expectated summary specifying title, 
                 # category, etc
@@ -213,7 +211,7 @@ def _run_batch_job_once_and_verify_output(
                     created_on=created_on,
                     last_updated=last_updated)
 
-                # calling constructor for field that are not required
+                # calling constructor for fields that are not required
                 # and have no default value does not work b/c
                 # unspecified fields will be empty list in
                 # expected_job_output but will be unspecified in