Skip to content

Commit

Permalink
add_comments: Remove warning about writing scores first
Browse files Browse the repository at this point in the history
This warning was no longer true--any missing scores are automatically
calculated and updated.

We actually have the opposite issue--the CommentTree must be updated
before writing scores because the QA score reads it.
  • Loading branch information
bsimpson63 committed Nov 14, 2016
1 parent c7d0f5b commit b227118
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions r2/r2/lib/comment_tree.py
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,6 @@ def add_comments(comments):
timer = g.stats.get_timer('comment_tree.add.1')
timer.start()

# write scores before CommentTree because the scores must exist for all
# comments in the tree
for sort in ("_controversy", "_confidence", "_score"):
scores_by_comment = {
comment._id36: getattr(comment, sort)
Expand Down

0 comments on commit b227118

Please sign in to comment.