Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework SQLite auto-increment introspection #6862

Merged
merged 1 commit into from
Mar 19, 2025
Merged

Rework SQLite auto-increment introspection #6862

merged 1 commit into from
Mar 19, 2025

Conversation

morozov
Copy link
Member

@morozov morozov commented Mar 19, 2025 •
edited
Loading

With this change, only INTEGER PRIMARY KEY AUTOINCREMENT SQLite columns will be introspected as auto-incremented. The INTEGER PRIMARY KEY ones won't. This way, the logic of introspection will be consistent with the logic of declaring the schema.

Fixes #6844.

@morozov morozov added this to the 5.0.0 milestone Mar 19, 2025
@morozov morozov linked an issue Mar 19, 2025 that may be closed by this pull request
Inconsistent semantics of auto-increment declaration and introspection on SQLite #6844
Closed
@morozov morozov marked this pull request as ready for review March 19, 2025 00:51
@morozov morozov requested a review from greg0ire March 19, 2025 00:51
@morozov morozov merged commit 48e87f5 into doctrine:5.0.x Mar 19, 2025
64 checks passed
@morozov morozov deleted the sqlite-auto-increment-introspection branch March 19, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg0ire greg0ire greg0ire approved these changes

Assignees
No one assigned
Labels
Auto-increment BC Break Bug Schema Introspection SQLite
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

Inconsistent semantics of auto-increment declaration and introspection on SQLite
2 participants
@morozov @greg0ire