Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement and test drop temporary table ... and show create table statements #8781

Merged
merged 7 commits into from
Jan 23, 2025

Conversation

jycor
Copy link
Contributor

@jycor jycor commented Jan 22, 2025

addresses the related issue here: #8762

Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -7670,4 +7670,40 @@ var DoltTempTableScripts = []queries.ScriptTest{
},
},
},
{
Name: "drop temporary table behavior",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should go in GMS

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they can't, gms doesn't support temporary tables

@coffeegoddd
Copy link
Contributor

@jycor DOLT

comparing_percentages
100.000000 to 100.000000
version result total
72ded6c ok 5937457
version total_tests
72ded6c 5937457
correctness_percentage
100.0

James Cor added 2 commits January 22, 2025 15:02
@coffeegoddd
Copy link
Contributor

@jycor DOLT

comparing_percentages
100.000000 to 100.000000
version result total
7869e4e ok 5937457
version total_tests
7869e4e 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@jycor DOLT

comparing_percentages
100.000000 to 100.000000
version result total
4aede6a ok 5937457
version total_tests
4aede6a 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@jycor DOLT

comparing_percentages
100.000000 to 100.000000
version result total
c9f28f7 ok 5937457
version total_tests
c9f28f7 5937457
correctness_percentage
100.0

@jycor jycor merged commit 009ab93 into main Jan 23, 2025
18 checks passed
@jycor jycor deleted the james/temp branch January 23, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants