1.10.782

[ci skip]
dongyi · Jan 20, 2018 · 5c12ab1 · 5c12ab1
1 parent 7e5cf9f
commit 5c12ab1
Show file tree

Hide file tree

Showing 53 changed files with 132 additions and 34 deletions.
diff --git a/build/ccxt.browser.js b/build/ccxt.browser.js
diff --git a/ccxt.js b/ccxt.js
@@ -37,7 +37,7 @@ const errors    = require ('./js/base/errors')
 //-----------------------------------------------------------------------------
 // this is updated by vss.js when building
 
-const version = '1.10.781'
+const version = '1.10.782'
 
 Exchange.ccxtVersion = version
 

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ccxt",
-  "version": "1.10.781",
+  "version": "1.10.782",
   "description": "A JavaScript / Python / PHP cryptocurrency trading library with support for 90+ exchanges",
   "main": "./ccxt.js",
   "unpkg": "build/ccxt.browser.js",

diff --git a/php/Exchange.php b/php/Exchange.php
@@ -30,7 +30,7 @@
 
 namespace ccxt;
 
-$version = '1.10.781';
+$version = '1.10.782';
 
 abstract class Exchange {
 

diff --git a/php/bibox.php b/php/bibox.php
@@ -22,6 +22,7 @@ public function describe () {
             'has' => array (
                 'fetchBalance' => true,
                 'fetchCurrencies' => true,
+                'fetchDepositAddress' => true,
                 'fetchTickers' => true,
                 'fetchOrders' => true,
                 'fetchMyTrades' => true,

diff --git a/php/binance.php b/php/binance.php
@@ -22,6 +22,7 @@ public function describe () {
             'hasWithdraw' => true,
             // new metainfo interface
             'has' => array (
+                'fetchDepositAddress' => true,
                 'fetchBidsAsks' => true,
                 'fetchTickers' => true,
                 'fetchOHLCV' => true,

diff --git a/php/bitfinex.php b/php/bitfinex.php
@@ -22,6 +22,8 @@ public function describe () {
             'hasFetchClosedOrders' => true,
             // new metainfo interface
             'has' => array (
+                'createDepositAddress' => true,
+                'fetchDepositAddress' => true,
                 'fetchOHLCV' => true,
                 'fetchTickers' => true,
                 'fetchOrder' => true,

diff --git a/php/bittrex.php b/php/bittrex.php
@@ -25,6 +25,7 @@ public function describe () {
             'hasWithdraw' => true,
             // new metainfo interface
             'has' => array (
+                'fetchDepositAddress' => true,
                 'fetchTickers' => true,
                 'fetchOHLCV' => true,
                 'fetchOrder' => true,

diff --git a/php/braziliex.php b/php/braziliex.php
@@ -16,6 +16,7 @@ public function describe () {
             'hasFetchMyTrades' => true,
             // new metainfo interface
             'has' => array (
+                'fetchDepositAddress' => true,
                 'fetchTickers' => true,
                 'fetchOpenOrders' => true,
                 'fetchMyTrades' => true,

diff --git a/php/cryptopia.php b/php/cryptopia.php
@@ -23,6 +23,7 @@ public function describe () {
             'hasWithdraw' => true,
             // new metainfo interface
             'has' => array (
+                'fetchDepositAddress' => true,
                 'fetchTickers' => true,
                 'fetchOrder' => 'emulated',
                 'fetchOrders' => 'emulated',

diff --git a/php/gdax.php b/php/gdax.php
@@ -531,14 +531,17 @@ public function handle_errors ($code, $reason, $url, $method, $headers, $body) {
             if ($body[0] === '{') {
                 $response = json_decode ($body, $as_associative_array = true);
                 $message = $response['message'];
+                $error = $this->id . ' ' . $message;
                 if (mb_strpos ($message, 'price too small') !== false) {
-                    throw new InvalidOrder ($this->id . ' ' . $message);
+                    throw new InvalidOrder ($error);
                 } else if (mb_strpos ($message, 'price too precise') !== false) {
-                    throw new InvalidOrder ($this->id . ' ' . $message);
+                    throw new InvalidOrder ($error);
+                } else if ($message === 'Insufficient funds') {
+                    throw new InsufficientFunds ($error);
                 } else if ($message === 'Invalid API Key') {
-                    throw new AuthenticationError ($this->id . ' ' . $message);
+                    throw new AuthenticationError ($error);
                 }
-                throw new ExchangeError ($this->id . ' ' . $this->json ($response));
+                throw new ExchangeError ($this->id . ' ' . $message);
             }
             throw new ExchangeError ($this->id . ' ' . $body);
         }

diff --git a/php/hitbtc2.php b/php/hitbtc2.php
@@ -24,6 +24,8 @@ public function describe () {
             'hasFetchCurrencies' => true,
             // new metainfo interface
             'has' => array (
+                'createDepositAddress' => true,
+                'fetchDepositAddress' => true,
                 'fetchCurrencies' => true,
                 'fetchOHLCV' => true,
                 'fetchTickers' => true,

diff --git a/php/kraken.php b/php/kraken.php
@@ -23,6 +23,8 @@ public function describe () {
             'hasFetchCurrencies' => true,
             // new metainfo interface
             'has' => array (
+                'createDepositAddress' => true,
+                'fetchDepositAddress' => true,
                 'fetchCurrencies' => true,
                 'fetchTickers' => true,
                 'fetchOHLCV' => true,

diff --git a/php/liqui.php b/php/liqui.php
@@ -622,7 +622,7 @@ public function sign ($path, $api = 'public', $method = 'GET', $params = array (
     }
 
     public function handle_errors ($httpCode, $reason, $url, $method, $headers, $body) {
-        if ((gettype ($body) != 'string') || (strlen ($body) < 2))
+        if ((gettype ($body) != 'string') && $body && (strlen ($body) < 2))
             return; // fallback to default error handler
         if (($body[0] === '{') || ($body[0] === '[')) {
             $response = json_decode ($body, $as_associative_array = true);

diff --git a/php/livecoin.php b/php/livecoin.php
@@ -16,6 +16,7 @@ public function describe () {
             'hasFetchCurrencies' => true,
             // new metainfo interface
             'has' => array (
+                'fetchDepositAddress' => true,
                 'fetchTickers' => true,
                 'fetchCurrencies' => true,
             ),

diff --git a/php/poloniex.php b/php/poloniex.php
@@ -23,6 +23,8 @@ public function describe () {
             'hasFetchOHLCV' => true,
             // new metainfo interface
             'has' => array (
+                'createDepositAddress' => true,
+                'fetchDepositAddress' => true,
                 'fetchOHLCV' => true,
                 'fetchMyTrades' => true,
                 'fetchOrder' => 'emulated',

diff --git a/php/quadrigacx.php b/php/quadrigacx.php
@@ -16,6 +16,7 @@ public function describe () {
             'hasWithdraw' => true,
             // new metainfo interface
             'has' => array (
+                'fetchDepositAddress' => true,
                 'withdraw' => true,
             ),
             'urls' => array (

diff --git a/php/yobit.php b/php/yobit.php
@@ -11,8 +11,14 @@ public function describe () {
             'countries' => 'RU',
             'rateLimit' => 3000, // responses are cached every 2 seconds
             'version' => '3',
+            // obsolete metainfo interface
             'hasCORS' => false,
             'hasWithdraw' => true,
+            // new metainfo interface
+            'has' => array (
+                'createDepositAddress' => true,
+                'fetchDepositAddress' => true,
+            ),
             'urls' => array (
                 'logo' => 'https://user-images.githubusercontent.com/1294454/27766910-cdcbfdae-5eea-11e7-9859-03fea873272d.jpg',
                 'api' => array (

diff --git a/php/zb.php b/php/zb.php
@@ -312,7 +312,7 @@ public function sign ($path, $api = 'public', $method = 'GET', $params = array (
             $this->check_required_credentials();
             $nonce = $this->nonce ();
             $auth = 'accesskey=' . $this->apiKey;
-            $auth .= '&$method=' . $path;
+            $auth .= '&' . 'method=' . $path;
             $secret = $this->hash ($this->encode ($this->secret), 'sha1');
             $signature = $this->hmac ($this->encode ($auth), $this->encode ($secret), 'md5');
             $suffix = 'sign=' . $signature . '&reqTime=' . (string) $nonce;

diff --git a/python/ccxt/__init__.py b/python/ccxt/__init__.py
@@ -28,7 +28,7 @@
 
 # ----------------------------------------------------------------------------
 
-__version__ = '1.10.781'
+__version__ = '1.10.782'
 
 # ----------------------------------------------------------------------------
 

diff --git a/python/ccxt/async/__init__.py b/python/ccxt/async/__init__.py
@@ -4,7 +4,7 @@
 
 # -----------------------------------------------------------------------------
 
-__version__ = '1.10.781'
+__version__ = '1.10.782'
 
 # -----------------------------------------------------------------------------
 

diff --git a/python/ccxt/async/base/exchange.py b/python/ccxt/async/base/exchange.py
@@ -2,7 +2,7 @@
 
 # -----------------------------------------------------------------------------
 
-__version__ = '1.10.781'
+__version__ = '1.10.782'
 
 # -----------------------------------------------------------------------------
 

diff --git a/python/ccxt/async/bibox.py b/python/ccxt/async/bibox.py
@@ -28,6 +28,7 @@ def describe(self):
             'has': {
                 'fetchBalance': True,
                 'fetchCurrencies': True,
+                'fetchDepositAddress': True,
                 'fetchTickers': True,
                 'fetchOrders': True,
                 'fetchMyTrades': True,

diff --git a/python/ccxt/async/binance.py b/python/ccxt/async/binance.py
@@ -30,6 +30,7 @@ def describe(self):
             'hasWithdraw': True,
             # new metainfo interface
             'has': {
+                'fetchDepositAddress': True,
                 'fetchBidsAsks': True,
                 'fetchTickers': True,
                 'fetchOHLCV': True,

diff --git a/python/ccxt/async/bitfinex.py b/python/ccxt/async/bitfinex.py
@@ -34,6 +34,8 @@ def describe(self):
             'hasFetchClosedOrders': True,
             # new metainfo interface
             'has': {
+                'createDepositAddress': True,
+                'fetchDepositAddress': True,
                 'fetchOHLCV': True,
                 'fetchTickers': True,
                 'fetchOrder': True,

diff --git a/python/ccxt/async/bittrex.py b/python/ccxt/async/bittrex.py
@@ -44,6 +44,7 @@ def describe(self):
             'hasWithdraw': True,
             # new metainfo interface
             'has': {
+                'fetchDepositAddress': True,
                 'fetchTickers': True,
                 'fetchOHLCV': True,
                 'fetchOrder': True,

diff --git a/python/ccxt/async/braziliex.py b/python/ccxt/async/braziliex.py
@@ -22,6 +22,7 @@ def describe(self):
             'hasFetchMyTrades': True,
             # new metainfo interface
             'has': {
+                'fetchDepositAddress': True,
                 'fetchTickers': True,
                 'fetchOpenOrders': True,
                 'fetchMyTrades': True,

diff --git a/python/ccxt/async/cryptopia.py b/python/ccxt/async/cryptopia.py
@@ -31,6 +31,7 @@ def describe(self):
             'hasWithdraw': True,
             # new metainfo interface
             'has': {
+                'fetchDepositAddress': True,
                 'fetchTickers': True,
                 'fetchOrder': 'emulated',
                 'fetchOrders': 'emulated',

diff --git a/python/ccxt/async/gdax.py b/python/ccxt/async/gdax.py
@@ -8,6 +8,7 @@
 from ccxt.base.errors import ExchangeError
 from ccxt.base.errors import NotSupported
 from ccxt.base.errors import AuthenticationError
+from ccxt.base.errors import InsufficientFunds
 from ccxt.base.errors import InvalidOrder
 
 
@@ -503,13 +504,16 @@ def handle_errors(self, code, reason, url, method, headers, body):
             if body[0] == '{':
                 response = json.loads(body)
                 message = response['message']
+                error = self.id + ' ' + message
                 if message.find('price too small') >= 0:
-                    raise InvalidOrder(self.id + ' ' + message)
+                    raise InvalidOrder(error)
                 elif message.find('price too precise') >= 0:
-                    raise InvalidOrder(self.id + ' ' + message)
+                    raise InvalidOrder(error)
+                elif message == 'Insufficient funds':
+                    raise InsufficientFunds(error)
                 elif message == 'Invalid API Key':
-                    raise AuthenticationError(self.id + ' ' + message)
-                raise ExchangeError(self.id + ' ' + self.json(response))
+                    raise AuthenticationError(error)
+                raise ExchangeError(self.id + ' ' + message)
             raise ExchangeError(self.id + ' ' + body)
 
     async def request(self, path, api='public', method='GET', params={}, headers=None, body=None):

diff --git a/python/ccxt/async/hitbtc2.py b/python/ccxt/async/hitbtc2.py
@@ -32,6 +32,8 @@ def describe(self):
             'hasFetchCurrencies': True,
             # new metainfo interface
             'has': {
+                'createDepositAddress': True,
+                'fetchDepositAddress': True,
                 'fetchCurrencies': True,
                 'fetchOHLCV': True,
                 'fetchTickers': True,

diff --git a/python/ccxt/async/kraken.py b/python/ccxt/async/kraken.py
@@ -35,6 +35,8 @@ def describe(self):
             'hasFetchCurrencies': True,
             # new metainfo interface
             'has': {
+                'createDepositAddress': True,
+                'fetchDepositAddress': True,
                 'fetchCurrencies': True,
                 'fetchTickers': True,
                 'fetchOHLCV': True,

diff --git a/python/ccxt/async/liqui.py b/python/ccxt/async/liqui.py
@@ -590,7 +590,7 @@ def sign(self, path, api='public', method='GET', params={}, headers=None, body=N
         return {'url': url, 'method': method, 'body': body, 'headers': headers}
 
     def handle_errors(self, httpCode, reason, url, method, headers, body):
-        if (not isinstance(body, basestring)) or len((body) < 2):
+        if (not isinstance(body, basestring)) and body and len((body) < 2):
             return  # fallback to default error handler
         if (body[0] == '{') or (body[0] == '['):
             response = json.loads(body)

diff --git a/python/ccxt/async/livecoin.py b/python/ccxt/async/livecoin.py
@@ -26,6 +26,7 @@ def describe(self):
             'hasFetchCurrencies': True,
             # new metainfo interface
             'has': {
+                'fetchDepositAddress': True,
                 'fetchTickers': True,
                 'fetchCurrencies': True,
             },

diff --git a/python/ccxt/async/poloniex.py b/python/ccxt/async/poloniex.py
@@ -33,6 +33,8 @@ def describe(self):
             'hasFetchOHLCV': True,
             # new metainfo interface
             'has': {
+                'createDepositAddress': True,
+                'fetchDepositAddress': True,
                 'fetchOHLCV': True,
                 'fetchMyTrades': True,
                 'fetchOrder': 'emulated',

diff --git a/python/ccxt/async/quadrigacx.py b/python/ccxt/async/quadrigacx.py
@@ -27,6 +27,7 @@ def describe(self):
             'hasWithdraw': True,
             # new metainfo interface
             'has': {
+                'fetchDepositAddress': True,
                 'withdraw': True,
             },
             'urls': {

diff --git a/python/ccxt/async/yobit.py b/python/ccxt/async/yobit.py
@@ -15,8 +15,14 @@ def describe(self):
             'countries': 'RU',
             'rateLimit': 3000,  # responses are cached every 2 seconds
             'version': '3',
+            # obsolete metainfo interface
             'hasCORS': False,
             'hasWithdraw': True,
+            # new metainfo interface
+            'has': {
+                'createDepositAddress': True,
+                'fetchDepositAddress': True,
+            },
             'urls': {
                 'logo': 'https://user-images.githubusercontent.com/1294454/27766910-cdcbfdae-5eea-11e7-9859-03fea873272d.jpg',
                 'api': {

diff --git a/python/ccxt/async/zb.py b/python/ccxt/async/zb.py
@@ -300,7 +300,7 @@ def sign(self, path, api='public', method='GET', params={}, headers=None, body=N
             self.check_required_credentials()
             nonce = self.nonce()
             auth = 'accesskey=' + self.apiKey
-            auth += '&method=' + path
+            auth += '&' + 'method=' + path
             secret = self.hash(self.encode(self.secret), 'sha1')
             signature = self.hmac(self.encode(auth), self.encode(secret), hashlib.md5)
             suffix = 'sign=' + signature + '&reqTime=' + str(nonce)

diff --git a/python/ccxt/base/exchange.py b/python/ccxt/base/exchange.py
@@ -4,7 +4,7 @@
 
 # -----------------------------------------------------------------------------
 
-__version__ = '1.10.781'
+__version__ = '1.10.782'
 
 # -----------------------------------------------------------------------------
 

diff --git a/python/ccxt/bibox.py b/python/ccxt/bibox.py
@@ -28,6 +28,7 @@ def describe(self):
             'has': {
                 'fetchBalance': True,
                 'fetchCurrencies': True,
+                'fetchDepositAddress': True,
                 'fetchTickers': True,
                 'fetchOrders': True,
                 'fetchMyTrades': True,

diff --git a/python/ccxt/binance.py b/python/ccxt/binance.py
@@ -30,6 +30,7 @@ def describe(self):
             'hasWithdraw': True,
             # new metainfo interface
             'has': {
+                'fetchDepositAddress': True,
                 'fetchBidsAsks': True,
                 'fetchTickers': True,
                 'fetchOHLCV': True,

diff --git a/python/ccxt/bitfinex.py b/python/ccxt/bitfinex.py
@@ -34,6 +34,8 @@ def describe(self):
             'hasFetchClosedOrders': True,
             # new metainfo interface
             'has': {
+                'createDepositAddress': True,
+                'fetchDepositAddress': True,
                 'fetchOHLCV': True,
                 'fetchTickers': True,
                 'fetchOrder': True,

diff --git a/python/ccxt/bittrex.py b/python/ccxt/bittrex.py
@@ -44,6 +44,7 @@ def describe(self):
             'hasWithdraw': True,
             # new metainfo interface
             'has': {
+                'fetchDepositAddress': True,
                 'fetchTickers': True,
                 'fetchOHLCV': True,
                 'fetchOrder': True,