1.13.139

[ci skip]

ccxt.js

@@ -37,7 +37,7 @@ const Exchange  = require ('./js/base/Exchange')
 //-----------------------------------------------------------------------------
 // this is updated by vss.js when building
 
-const version = '1.13.138'
+const version = '1.13.139'
 
 Exchange.ccxtVersion = version
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "ccxt",
-  "version": "1.13.138",
+  "version": "1.13.139",
   "description": "A JavaScript / Python / PHP cryptocurrency trading library with support for 100+ exchanges",
   "main": "./ccxt.js",
   "unpkg": "build/ccxt.browser.js",

php/Exchange.php

@@ -30,7 +30,7 @@
 
 namespace ccxt;
 
-$version = '1.13.138';
+$version = '1.13.139';
 
 // rounding mode
 const TRUNCATE = 0;

php/bithumb.php

@@ -276,16 +276,16 @@ public function create_order ($symbol, $type, $side, $amount, $price = null, $pa
     }
 
     public function cancel_order ($id, $symbol = null, $params = array ()) {
-        $side = (is_array ($params) && array_key_exists ('side', $params));
-        if (!$side)
+        $side_in_params = (is_array ($params) && array_key_exists ('side', $params));
+        if (!$side_in_params)
             throw new ExchangeError ($this->id . ' cancelOrder requires a $side parameter (sell or buy) and a $currency parameter');
-        $side = ($side === 'buy') ? 'purchase' : 'sales';
         $currency = (is_array ($params) && array_key_exists ('currency', $params));
         if (!$currency)
             throw new ExchangeError ($this->id . ' cancelOrder requires a $currency parameter');
+        $side = ($params['side'] === 'buy') ? 'bid' : 'ask';
         return $this->privatePostTradeCancel (array (
             'order_id' => $id,
-            'type' => $params['side'],
+            'type' => $side,
             'currency' => $params['currency'],
         ));
     }

python/ccxt/__init__.py

@@ -22,7 +22,7 @@
 
 # ----------------------------------------------------------------------------
 
-__version__ = '1.13.138'
+__version__ = '1.13.139'
 
 # ----------------------------------------------------------------------------
 

python/ccxt/async/__init__.py

@@ -4,7 +4,7 @@
 
 # -----------------------------------------------------------------------------
 
-__version__ = '1.13.138'
+__version__ = '1.13.139'
 
 # -----------------------------------------------------------------------------
 

python/ccxt/async/base/exchange.py

@@ -2,7 +2,7 @@
 
 # -----------------------------------------------------------------------------
 
-__version__ = '1.13.138'
+__version__ = '1.13.139'
 
 # -----------------------------------------------------------------------------
 

python/ccxt/async/bithumb.py

@@ -261,16 +261,16 @@ async def create_order(self, symbol, type, side, amount, price=None, params={}):
         }
 
     async def cancel_order(self, id, symbol=None, params={}):
-        side = ('side' in list(params.keys()))
-        if not side:
+        side_in_params = ('side' in list(params.keys()))
+        if not side_in_params:
             raise ExchangeError(self.id + ' cancelOrder requires a side parameter(sell or buy) and a currency parameter')
-        side = 'purchase' if (side == 'buy') else 'sales'
         currency = ('currency' in list(params.keys()))
         if not currency:
             raise ExchangeError(self.id + ' cancelOrder requires a currency parameter')
+        side = 'bid' if (params['side'] == 'buy') else 'ask'
         return await self.privatePostTradeCancel({
             'order_id': id,
-            'type': params['side'],
+            'type': side,
             'currency': params['currency'],
         })
 

python/ccxt/base/exchange.py

@@ -4,7 +4,7 @@
 
 # -----------------------------------------------------------------------------
 
-__version__ = '1.13.138'
+__version__ = '1.13.139'
 
 # -----------------------------------------------------------------------------
 

python/ccxt/bithumb.py

@@ -261,16 +261,16 @@ def create_order(self, symbol, type, side, amount, price=None, params={}):
         }
 
     def cancel_order(self, id, symbol=None, params={}):
-        side = ('side' in list(params.keys()))
-        if not side:
+        side_in_params = ('side' in list(params.keys()))
+        if not side_in_params:
             raise ExchangeError(self.id + ' cancelOrder requires a side parameter(sell or buy) and a currency parameter')
-        side = 'purchase' if (side == 'buy') else 'sales'
         currency = ('currency' in list(params.keys()))
         if not currency:
             raise ExchangeError(self.id + ' cancelOrder requires a currency parameter')
+        side = 'bid' if (params['side'] == 'buy') else 'ask'
         return self.privatePostTradeCancel({
             'order_id': id,
-            'type': params['side'],
+            'type': side,
             'currency': params['currency'],
         })