fix(UVE): Add correct label to bookmark on old toolbar #31114
Merged
+16
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zJaaal
requested review from
fmontes,
oidacra,
nicobytes,
hmoreras,
valentinogiardino and
nollymar
oidacra
approved these changes
Jan 13, 2025
nollymar
approved these changes
Jan 13, 2025
KevinDavilaDotCMS
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
DotEmaBookmarksComponentto adjust the label behavior based on the preview mode and to add corresponding test cases. The most important changes include updating the label logic and adding tests to ensure the correct label is displayed in different preview modes.Label logic update:
core-web/libs/portlets/edit-ema/portlet/src/lib/edit-ema-editor/components/dot-uve-toolbar/components/dot-ema-bookmarks/dot-ema-bookmarks.component.html: Modified the label to beeditpage.toolbar.bookmarkwhen not in preview mode.Test cases addition:
core-web/libs/portlets/edit-ema/portlet/src/lib/edit-ema-editor/components/dot-uve-toolbar/components/dot-ema-bookmarks/dot-ema-bookmarks.component.spec.ts: Added a test to check that the label is present when preview mode is false.core-web/libs/portlets/edit-ema/portlet/src/lib/edit-ema-editor/components/dot-uve-toolbar/components/dot-ema-bookmarks/dot-ema-bookmarks.component.spec.ts: Added a test to check that the label is not present when preview mode is true.Screenshots
This PR fixes: #31095