Support required properties #2579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aelij some of the tests are failing, PTAL. |
aelij
force-pushed
the
required-property
branch
from
32495a9 to
469f034
Compare
|
@adamsitnik Sorry the PR slipped my mind. All tests pass now, I took a different approach. |
timcassell
requested changes
Mar 29, 2025
timcassell
approved these changes
Mar 30, 2025
There was a problem hiding this comment.
Since the "SmartParameter" supports instance methods, it looks like this is the only way to do this. Thanks @aelij!
|
@aelij I just realized after merging that you didn't add tests for InProcess toolchains. Would you mind doing a follow-up to add those? |
|
Sure. @timcassell can you point me where this test should go? |
|
InProcessTest and InProcessEmitTest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.