[Xamarin.Android.Build.Tasks] make "managed typemap" runtime agnostic #9911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanpeppers
force-pushed
the
dev/peppers/runtime-agnostic-typemap
branch
from
79061b4 to
32a898f
Compare
jonathanpeppers
commented
Mar 12, 2025
Comment on lines
+86
to
+89
| if (TypemapImplementation != "llvm-ir") { | ||
| Log.LogDebugMessage ($"TypemapImplementation='{TypemapImplementation}' will write an empty native typemap."); | ||
| state = new NativeCodeGenState (state.TargetArch, new TypeDefinitionCache (), state.Resolver, [], [], state.Classifier); | ||
| } |
There was a problem hiding this comment.
Instead of returning early, I made this write the native assembly with a typemap of 0 entries, this prevents the crash at runtime:
03-12 12:36:53.682 29155 29155 E AndroidRuntime: java.lang.UnsatisfiedLinkError: dlopen failed: cannot locate symbol "java_type_count" referenced by "/data/app/~~sPVK03Ot__92Sd7QEgoNXw==/com.companyname.helloandroid-EN9cYvEYQtDuCTIXF_jW0Q==/split_config.arm64_v8a.apk!/lib/arm64-v8a/libmonodroid.so"...
a4a2896 to
5468780
Compare
For NativeAOT, we implemented a "managed" typemap that is trimmer-safe. In order to test its performance characteristics, we can make this typemap useable for Mono and CoreCLR as well: * Move `NativeAotTypeManager`, `NativeAotValueManager`, and `TypeMapping` types to `Mono.Android.dll` * Rename `NativeAot*` to `Managed*` * Add a new private `$(_AndroidTypeMapImplementation)` MSBuild property that can be set to `llvm-ir` or `managed`. * Add a new trimmer feature flag `Android.Runtime.RuntimeFeature.ManagedTypeMap` that when `true` uses the managed typemap on any runtime. I added a test that verifies `dotnet run` succeeds for all typemap implementations. Note that NativeAOT will *only* support the managed typemap.
jonathanpeppers
force-pushed
the
dev/peppers/runtime-agnostic-typemap
branch
from
827ff6b to
ffef891
Compare
dellis1972
approved these changes
Mar 27, 2025
jonathanpeppers
commented
Mar 27, 2025
We want to be able to test the performance of the managed typemap vs the native one. Ideally, we'd do this using the same runtime, so either Mono or CoreCLR. |
jonpryor
reviewed
Mar 27, 2025
|
This test is failing on all PRs currently:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For NativeAOT, we implemented a "managed" typemap that is trimmer-safe.
In order to test its performance characteristics, we can make this typemap useable for Mono and CoreCLR as well:
Move
NativeAotTypeManager,NativeAotValueManager, andTypeMappingtypes toMono.Android.dllRename
NativeAot*toManaged*Add a new private
$(_AndroidTypeMapImplementation)MSBuild property that can be set tollvm-irormanaged.Add a new trimmer feature flag
Microsoft.Android.Runtime.RuntimeFeature.ManagedTypeMapthat whentrueuses the managed typemap on any runtime.I added a test that verifies
dotnet runsucceeds for all typemap implementations.Note that NativeAOT will only support the managed typemap.