Skip to content

Add WithDashboard() method to allow opting out of Aspire dashboard in Azure Container App environments #9600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 31, 2025

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented May 30, 2025

This PR adds the ability for users to disable the Aspire dashboard in Azure Container App environments through a new WithDashboard(bool enable = true) extension method.

Problem

Previously, the Aspire dashboard was always added to Azure Container App environments with no way to opt out. This created unnecessary resources for users who didn't want the dashboard functionality.

Solution

Added a new WithDashboard(bool enable = true) extension method that allows users to control dashboard inclusion:

// Default behavior (dashboard enabled) - unchanged for backward compatibility
builder.AddAzureContainerAppEnvironment("env");

// Explicitly enable dashboard
builder.AddAzureContainerAppEnvironment("env").WithDashboard(true);

// Disable dashboard (new functionality)
builder.AddAzureContainerAppEnvironment("env").WithDashboard(false);

Implementation Details

  1. Added EnableDashboard property to AzureContainerAppEnvironmentResource (defaults to true)
  2. Added WithDashboard(bool enable = true) extension method for fluent configuration
  3. Modified infrastructure creation logic to conditionally add the dashboard resource based on the EnableDashboard property
  4. Updated API surface to include the new extension method
  5. Added tests to verify both enabled and disabled scenarios

The dashboard resource creation is now wrapped in a conditional check:

if (appEnvResource.EnableDashboard)
{
    var dashboard = new ContainerAppEnvironmentDotnetComponentResource("aspireDashboard", "2024-10-02-preview")
    {
        Name = "aspire-dashboard",
        ComponentType = "AspireDashboard",
        Parent = containerAppEnvironment
    };
    infra.Add(dashboard);
}

Backward Compatibility

The default behavior remains unchanged - the dashboard is enabled by default, ensuring existing code continues to work without modification.

Fixes #9599.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

  • 0t3vsblobprodcus362.vsblob.vsassets.io
    • Triggering command: ./.dotnet/dotnet test tests/Aspire.Hosting.Azure.Tests/Aspire.Hosting.Azure.Tests.csproj --filter AddContainerAppEnvironmentAddsEnvironmentResource --verbosity minimal (dns block)
  • 7devsblobprodcus323.vsblob.vsassets.io
    • Triggering command: ./.dotnet/dotnet test tests/Aspire.Hosting.Azure.Tests/Aspire.Hosting.Azure.Tests.csproj --filter AddContainerAppEnvironmentAddsEnvironmentResource --verbosity minimal (dns block)
  • 7k6vsblobprodcus337.vsblob.vsassets.io
    • Triggering command: ./.dotnet/dotnet test tests/Aspire.Hosting.Azure.Tests/Aspire.Hosting.Azure.Tests.csproj --filter AddContainerAppEnvironmentAddsEnvironmentResource --verbosity minimal (dns block)
  • dlbvsblobprodcus316.vsblob.vsassets.io
    • Triggering command: ./.dotnet/dotnet test tests/Aspire.Hosting.Azure.Tests/Aspire.Hosting.Azure.Tests.csproj --filter AddContainerAppEnvironmentAddsEnvironmentResource --verbosity minimal (dns block)
  • h6tvsblobprodcus346.vsblob.vsassets.io
    • Triggering command: ./.dotnet/dotnet test tests/Aspire.Hosting.Azure.Tests/Aspire.Hosting.Azure.Tests.csproj --filter AddContainerAppEnvironmentAddsEnvironmentResource --verbosity minimal (dns block)
  • i1qvsblobprodcus353.vsblob.vsassets.io
    • Triggering command: ./.dotnet/dotnet test tests/Aspire.Hosting.Azure.Tests/Aspire.Hosting.Azure.Tests.csproj --filter AddContainerAppEnvironmentAddsEnvironmentResource --verbosity minimal (dns block)
  • imzvsblobprodcus368.vsblob.vsassets.io
    • Triggering command: ./.dotnet/dotnet test tests/Aspire.Hosting.Azure.Tests/Aspire.Hosting.Azure.Tests.csproj --filter AddContainerAppEnvironmentAddsEnvironmentResource --verbosity minimal (dns block)
  • jd4vsblobprodcus366.vsblob.vsassets.io
    • Triggering command: ./.dotnet/dotnet test tests/Aspire.Hosting.Azure.Tests/Aspire.Hosting.Azure.Tests.csproj --filter AddContainerAppEnvironmentAddsEnvironmentResource --verbosity minimal (dns block)
  • kh4vsblobprodcus325.vsblob.vsassets.io
    • Triggering command: ./.dotnet/dotnet test tests/Aspire.Hosting.Azure.Tests/Aspire.Hosting.Azure.Tests.csproj --filter AddContainerAppEnvironmentAddsEnvironmentResource --verbosity minimal (dns block)
  • l49vsblobprodcus358.vsblob.vsassets.io
    • Triggering command: ./.dotnet/dotnet test tests/Aspire.Hosting.Azure.Tests/Aspire.Hosting.Azure.Tests.csproj --filter AddContainerAppEnvironmentAddsEnvironmentResource --verbosity minimal (dns block)
  • ofvvsblobprodcus315.vsblob.vsassets.io
    • Triggering command: ./.dotnet/dotnet test tests/Aspire.Hosting.Azure.Tests/Aspire.Hosting.Azure.Tests.csproj --filter AddContainerAppEnvironmentAddsEnvironmentResource --verbosity minimal (dns block)
  • p2ovsblobprodcus312.vsblob.vsassets.io
    • Triggering command: ./.dotnet/dotnet test tests/Aspire.Hosting.Azure.Tests/Aspire.Hosting.Azure.Tests.csproj --filter AddContainerAppEnvironmentAddsEnvironmentResource --verbosity minimal (dns block)
  • pe4vsblobprodcus351.vsblob.vsassets.io
    • Triggering command: ./.dotnet/dotnet test tests/Aspire.Hosting.Azure.Tests/Aspire.Hosting.Azure.Tests.csproj --filter AddContainerAppEnvironmentAddsEnvironmentResource --verbosity minimal (dns block)
  • x3yvsblobprodcus370.vsblob.vsassets.io
    • Triggering command: ./.dotnet/dotnet test tests/Aspire.Hosting.Azure.Tests/Aspire.Hosting.Azure.Tests.csproj --filter AddContainerAppEnvironmentAddsEnvironmentResource --verbosity minimal (dns block)

If you need me to access, download, or install something from one of these locations, you can either:


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@Copilot Copilot AI changed the title [WIP] Make it possible to opt-out of the aspire dashboard in container app environment resource Add WithDashboard() method to allow opting out of Aspire dashboard in Azure Container App environments May 31, 2025
@Copilot Copilot AI requested a review from davidfowl May 31, 2025 00:05
Copilot finished work on behalf of davidfowl May 31, 2025 00:05
Copy link
Contributor Author

Copilot AI commented May 31, 2025

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

  • 0t3vsblobprodcus362.vsblob.vsassets.io
    • Triggering command: ./.dotnet/dotnet test tests/Aspire.Hosting.Azure.Tests/Aspire.Hosting.Azure.Tests.csproj --filter AzureContainerApp --verbosity minimal (dns block)
  • 7devsblobprodcus323.vsblob.vsassets.io
    • Triggering command: ./.dotnet/dotnet test tests/Aspire.Hosting.Azure.Tests/Aspire.Hosting.Azure.Tests.csproj --filter AzureContainerApp --verbosity minimal (dns block)
  • 7k6vsblobprodcus337.vsblob.vsassets.io
    • Triggering command: ./.dotnet/dotnet test tests/Aspire.Hosting.Azure.Tests/Aspire.Hosting.Azure.Tests.csproj --filter AzureContainerApp --verbosity minimal (dns block)
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (dns block)
  • dlbvsblobprodcus316.vsblob.vsassets.io
    • Triggering command: ./.dotnet/dotnet test tests/Aspire.Hosting.Azure.Tests/Aspire.Hosting.Azure.Tests.csproj --filter AzureContainerApp --verbosity minimal (dns block)
  • h6tvsblobprodcus346.vsblob.vsassets.io
    • Triggering command: ./.dotnet/dotnet test tests/Aspire.Hosting.Azure.Tests/Aspire.Hosting.Azure.Tests.csproj --filter AzureContainerApp --verbosity minimal (dns block)
  • i1qvsblobprodcus353.vsblob.vsassets.io
    • Triggering command: ./.dotnet/dotnet test tests/Aspire.Hosting.Azure.Tests/Aspire.Hosting.Azure.Tests.csproj --filter AzureContainerApp --verbosity minimal (dns block)
  • imzvsblobprodcus368.vsblob.vsassets.io
    • Triggering command: ./.dotnet/dotnet test tests/Aspire.Hosting.Azure.Tests/Aspire.Hosting.Azure.Tests.csproj --filter AzureContainerApp --verbosity minimal (dns block)
  • jd4vsblobprodcus366.vsblob.vsassets.io
    • Triggering command: ./.dotnet/dotnet test tests/Aspire.Hosting.Azure.Tests/Aspire.Hosting.Azure.Tests.csproj --filter AzureContainerApp --verbosity minimal (dns block)
  • kh4vsblobprodcus325.vsblob.vsassets.io
    • Triggering command: ./.dotnet/dotnet test tests/Aspire.Hosting.Azure.Tests/Aspire.Hosting.Azure.Tests.csproj --filter AzureContainerApp --verbosity minimal (dns block)
  • l49vsblobprodcus358.vsblob.vsassets.io
    • Triggering command: ./.dotnet/dotnet test tests/Aspire.Hosting.Azure.Tests/Aspire.Hosting.Azure.Tests.csproj --filter AzureContainerApp --verbosity minimal (dns block)
  • ofvvsblobprodcus315.vsblob.vsassets.io
    • Triggering command: ./.dotnet/dotnet test tests/Aspire.Hosting.Azure.Tests/Aspire.Hosting.Azure.Tests.csproj --filter AzureContainerApp --verbosity minimal (dns block)
  • p2ovsblobprodcus312.vsblob.vsassets.io
    • Triggering command: ./.dotnet/dotnet test tests/Aspire.Hosting.Azure.Tests/Aspire.Hosting.Azure.Tests.csproj --filter AzureContainerApp --verbosity minimal (dns block)
  • pe4vsblobprodcus351.vsblob.vsassets.io
    • Triggering command: ./.dotnet/dotnet test tests/Aspire.Hosting.Azure.Tests/Aspire.Hosting.Azure.Tests.csproj --filter AzureContainerApp --verbosity minimal (dns block)
  • x3yvsblobprodcus370.vsblob.vsassets.io
    • Triggering command: ./.dotnet/dotnet test tests/Aspire.Hosting.Azure.Tests/Aspire.Hosting.Azure.Tests.csproj --filter AzureContainerApp --verbosity minimal (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot finished work on behalf of davidfowl May 31, 2025 00:24
@davidfowl davidfowl marked this pull request as ready for review May 31, 2025 00:48
@davidfowl davidfowl enabled auto-merge (squash) May 31, 2025 01:23
@davidfowl davidfowl disabled auto-merge May 31, 2025 01:23
@davidfowl davidfowl requested a review from vhvb1989 May 31, 2025 01:24
@davidfowl
Copy link
Member

FYI @vhvb1989 this might require changes to azd to handle the no dashboard case.

@davidfowl davidfowl enabled auto-merge (squash) May 31, 2025 01:24
@davidfowl davidfowl disabled auto-merge May 31, 2025 03:06
@davidfowl davidfowl merged commit e8869a1 into main May 31, 2025
1236 of 1246 checks passed
@davidfowl davidfowl deleted the copilot/fix-9599 branch May 31, 2025 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it possible to opt-out of the aspire dashboard in container app environment resource
3 participants