-
Notifications
You must be signed in to change notification settings - Fork 637
Add WithDashboard() method to allow opting out of Aspire dashboard in Azure Container App environments #9600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vironments Co-authored-by: davidfowl <[email protected]>
Copilot finished work on behalf of
davidfowl
May 31, 2025 00:05
davidfowl
reviewed
May 31, 2025
src/Aspire.Hosting.Azure.AppContainers/api/Aspire.Hosting.Azure.AppContainers.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: davidfowl <[email protected]>
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot finished work on behalf of
davidfowl
May 31, 2025 00:24
mitchdenny
approved these changes
May 31, 2025
FYI @vhvb1989 this might require changes to azd to handle the no dashboard case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability for users to disable the Aspire dashboard in Azure Container App environments through a new
WithDashboard(bool enable = true)
extension method.Problem
Previously, the Aspire dashboard was always added to Azure Container App environments with no way to opt out. This created unnecessary resources for users who didn't want the dashboard functionality.
Solution
Added a new
WithDashboard(bool enable = true)
extension method that allows users to control dashboard inclusion:Implementation Details
EnableDashboard
property toAzureContainerAppEnvironmentResource
(defaults totrue
)WithDashboard(bool enable = true)
extension method for fluent configurationEnableDashboard
propertyThe dashboard resource creation is now wrapped in a conditional check:
Backward Compatibility
The default behavior remains unchanged - the dashboard is enabled by default, ensuring existing code continues to work without modification.
Fixes #9599.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
0t3vsblobprodcus362.vsblob.vsassets.io
./.dotnet/dotnet test tests/Aspire.Hosting.Azure.Tests/Aspire.Hosting.Azure.Tests.csproj --filter AddContainerAppEnvironmentAddsEnvironmentResource --verbosity minimal
(dns block)7devsblobprodcus323.vsblob.vsassets.io
./.dotnet/dotnet test tests/Aspire.Hosting.Azure.Tests/Aspire.Hosting.Azure.Tests.csproj --filter AddContainerAppEnvironmentAddsEnvironmentResource --verbosity minimal
(dns block)7k6vsblobprodcus337.vsblob.vsassets.io
./.dotnet/dotnet test tests/Aspire.Hosting.Azure.Tests/Aspire.Hosting.Azure.Tests.csproj --filter AddContainerAppEnvironmentAddsEnvironmentResource --verbosity minimal
(dns block)dlbvsblobprodcus316.vsblob.vsassets.io
./.dotnet/dotnet test tests/Aspire.Hosting.Azure.Tests/Aspire.Hosting.Azure.Tests.csproj --filter AddContainerAppEnvironmentAddsEnvironmentResource --verbosity minimal
(dns block)h6tvsblobprodcus346.vsblob.vsassets.io
./.dotnet/dotnet test tests/Aspire.Hosting.Azure.Tests/Aspire.Hosting.Azure.Tests.csproj --filter AddContainerAppEnvironmentAddsEnvironmentResource --verbosity minimal
(dns block)i1qvsblobprodcus353.vsblob.vsassets.io
./.dotnet/dotnet test tests/Aspire.Hosting.Azure.Tests/Aspire.Hosting.Azure.Tests.csproj --filter AddContainerAppEnvironmentAddsEnvironmentResource --verbosity minimal
(dns block)imzvsblobprodcus368.vsblob.vsassets.io
./.dotnet/dotnet test tests/Aspire.Hosting.Azure.Tests/Aspire.Hosting.Azure.Tests.csproj --filter AddContainerAppEnvironmentAddsEnvironmentResource --verbosity minimal
(dns block)jd4vsblobprodcus366.vsblob.vsassets.io
./.dotnet/dotnet test tests/Aspire.Hosting.Azure.Tests/Aspire.Hosting.Azure.Tests.csproj --filter AddContainerAppEnvironmentAddsEnvironmentResource --verbosity minimal
(dns block)kh4vsblobprodcus325.vsblob.vsassets.io
./.dotnet/dotnet test tests/Aspire.Hosting.Azure.Tests/Aspire.Hosting.Azure.Tests.csproj --filter AddContainerAppEnvironmentAddsEnvironmentResource --verbosity minimal
(dns block)l49vsblobprodcus358.vsblob.vsassets.io
./.dotnet/dotnet test tests/Aspire.Hosting.Azure.Tests/Aspire.Hosting.Azure.Tests.csproj --filter AddContainerAppEnvironmentAddsEnvironmentResource --verbosity minimal
(dns block)ofvvsblobprodcus315.vsblob.vsassets.io
./.dotnet/dotnet test tests/Aspire.Hosting.Azure.Tests/Aspire.Hosting.Azure.Tests.csproj --filter AddContainerAppEnvironmentAddsEnvironmentResource --verbosity minimal
(dns block)p2ovsblobprodcus312.vsblob.vsassets.io
./.dotnet/dotnet test tests/Aspire.Hosting.Azure.Tests/Aspire.Hosting.Azure.Tests.csproj --filter AddContainerAppEnvironmentAddsEnvironmentResource --verbosity minimal
(dns block)pe4vsblobprodcus351.vsblob.vsassets.io
./.dotnet/dotnet test tests/Aspire.Hosting.Azure.Tests/Aspire.Hosting.Azure.Tests.csproj --filter AddContainerAppEnvironmentAddsEnvironmentResource --verbosity minimal
(dns block)x3yvsblobprodcus370.vsblob.vsassets.io
./.dotnet/dotnet test tests/Aspire.Hosting.Azure.Tests/Aspire.Hosting.Azure.Tests.csproj --filter AddContainerAppEnvironmentAddsEnvironmentResource --verbosity minimal
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.