Skip to content

Fix path filter for template test PR job #62485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2025
Merged

Fix path filter for template test PR job #62485

merged 1 commit into from
Jun 26, 2025

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Jun 26, 2025

Docs claim it should be **/*, but apparently they're wrong. Runtime does it w/ one wildcard. I also tested this out here: #62484

@wtgodbe wtgodbe requested a review from Copilot June 26, 2025 21:29
@wtgodbe wtgodbe requested a review from a team as a code owner June 26, 2025 21:29
@github-actions github-actions bot added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Jun 26, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Azure Pipelines file filter for the template test PR job, correcting the wildcard pattern to match the runtime’s supported syntax.

  • Switched the path include from a recursive **/* pattern to a single-level * pattern.
Comments suppressed due to low confidence (1)

.azure/pipelines/template-tests-pr.yml:19

  • The pattern src/ProjectTemplates/* only matches files and folders one level deep; changes in nested subdirectories won’t trigger this job. Consider using a supported recursive pattern (e.g., if the runtime allows src/ProjectTemplates/**) or adjusting directory layouts so that all relevant template changes are included.
    - src/ProjectTemplates/*

@wtgodbe wtgodbe merged commit 17b7c79 into main Jun 26, 2025
4 of 6 checks passed
@wtgodbe wtgodbe deleted the wtgodbe/pathfilt branch June 26, 2025 21:29
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview7 milestone Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant