Skip to content

Clarify method renaming and async return types #46110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025

Conversation

MBSadeghzadeh
Copy link
Contributor

@MBSadeghzadeh MBSadeghzadeh commented May 14, 2025

Summary

Updated the documentation to clarify that the original methods—FryEggs, FryBacon, and ToastBread—were modified to return Task, Task, and Task respectively. The asynchronous versions—FryEggsAsync, FryBaconAsync, and ToastBreadAsync—did not exist prior to this point in the documentation; they are being introduced here for the first time, not updated.


Internal previews

📄 File 🔗 Preview link
docs/csharp/asynchronous-programming/index.md docs/csharp/asynchronous-programming/index

Updated the documentation to clarify that the original methods—FryEggs, FryBacon, and ToastBread—were modified to return Task<Egg>, Task<Bacon>, and Task<Toast> respectively. The asynchronous versions—FryEggsAsync, FryBaconAsync, and ToastBreadAsync—did not exist prior to this point in the documentation; they are being introduced here for the first time, not updated.
@MBSadeghzadeh MBSadeghzadeh requested review from BillWagner and a team as code owners May 14, 2025 11:41
@dotnetrepoman dotnetrepoman bot added this to the May 2025 milestone May 14, 2025
@dotnet-policy-service dotnet-policy-service bot added dotnet-csharp/svc async-task-programming/subsvc community-contribution Indicates PR is created by someone from the .NET community. labels May 14, 2025
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MBSadeghzadeh

This looks great, and I'll :shipit: now.

@BillWagner BillWagner merged commit c42af57 into dotnet:main May 14, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
async-task-programming/subsvc community-contribution Indicates PR is created by someone from the .NET community. dotnet-csharp/svc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants