remove Dispose call on ShellItemRenderer #27890
Open
+1
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWeen
reviewed
Feb 18, 2025
src/Controls/src/Core/Compatibility/Handlers/Shell/Android/ShellRenderer.cs
Show resolved
Hide resolved
|
Hi @pictos. We have added the "s/pr-needs-author-input" label to this issue, which indicates that we have an open question/action for you before we can take further action. This PRwill be closed automatically in 14 days if we do not hear back from you by then - please feel free to re-open it if you come back to this PR after that time. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
rmarinho
approved these changes
Feb 20, 2025
|
/rebase |
github-actions
bot
force-pushed
the
pj/fix-shell-flyout-navigation
branch
from
9f57dc8 to
83520d9
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
can we remove the label |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Remove the
Disposecall that happens duringOnDestroylifecycle. If user has added aFragmentManager.FragmentLifecycleCallbackstheFragment, that represents theShellItemwill be disposed too earlier causing in an app crash. Removing theDiposecall will make sure that theFragmentlives long enough to pass to all lifecycle methods.Issues Fixed
Fixes #27889