Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create benchmarks for System.Threading.Tasks.Dataflow #951
base: main
Are you sure you want to change the base?
Create benchmarks for System.Threading.Tasks.Dataflow #951
Changes from 17 commits
aaca250
c529438
c5a4d94
9c1b400
d1a5180
c8a7c09
432afcf
36c8cd5
a12eb17
bc69b86
11eb153
8ee7a19
9b92331
e43520b
93640b3
f6e97aa
d18d87a
5df8fbb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this GlobalSetup still needed when we're calling BlockSetup on each benchmark invocation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We only call
BlockSetup
from the benchmark code when we are forced to callComplete
on the tested block to have a valid test case. This concerns only two benchmarks.