Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blittable color #106575

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Blittable color #106575

wants to merge 4 commits into from

Conversation

AlexRadch
Copy link
Contributor

Close #48615

@dotnet-issue-labeler dotnet-issue-labeler bot added needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners new-api-needs-documentation labels Aug 17, 2024
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

1 similar comment
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Aug 17, 2024
@jkotas jkotas added area-System.Numerics and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Aug 17, 2024
@tannergooding
Copy link
Member

CC. @JeremyKuhne, is WinForms ready to start using these types if exposed?

Adding them has only been blocked as that was the primary user and we didn't want to expose them without WinForms adopting them in the same release

Rgba.Tests
@JeremyKuhne
Copy link
Member

@tannergooding I'll be consuming this in WinForms WPF this cycle after it goes in.

@@ -0,0 +1,29 @@
<Project Sdk="Microsoft.NET.Sdk">
Copy link
Member

@tannergooding tannergooding Jan 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was talking with @JeremyKuhne and his expectation matched mine, which was this was going to be part of the existing System.Numerics.Vectors package rather than a net new package.

Particularly for acceleration and support around float, there is likely to be a need for these (the color and existing Vector4/Matrix4x4/etc types) to be used in conjunction. The "downside" is that since System.Numerics.Vectors is in-box and frozen downlevel these new types would never be available on .NET Framework. However, that isn't a concern from the WinForms/WPF team (much as any of the other new graphics related vector/matrix/plane/etc APIs aren't available downlevel).

CC. @ericstj, just for additional confirmation there isn't something we're missing here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.Numerics community-contribution Indicates that the PR has been added by a community member new-api-needs-documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API Proposal: Add blittable Color to System.Numerics
4 participants