Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] Fix nativeaot outerloop #109010

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 18, 2024

Backport of #108916 to release/8.0

/cc @MichalStrehovsky

Tell mode: #108550 added a trim-unfriendly test and nativeaot outerloop testing has been broken ever since. This fixes the test.

@tarekgh tarekgh added this to the 8.0.x milestone Oct 18, 2024
@tarekgh
Copy link
Member

tarekgh commented Oct 18, 2024

CC @ericstj @artl93 this is test only change and against 9.0/release branch. Just in case you have any comment here.

@ericstj
Copy link
Member

ericstj commented Dec 17, 2024

this needs to target release/8.0-staging.

@ericstj ericstj changed the base branch from release/8.0 to release/8.0-staging December 17, 2024 16:05
@ericstj ericstj added the Servicing-approved Approved for servicing release label Dec 17, 2024
@ericstj
Copy link
Member

ericstj commented Dec 17, 2024

Marking as approved since this is tell mode test change.

@ericstj
Copy link
Member

ericstj commented Jan 7, 2025

/azp run

Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@ericstj
Copy link
Member

ericstj commented Jan 7, 2025

/azp run runtime

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@MichalStrehovsky
Copy link
Member

/azp run runtime-nativeaot-outerloop

Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@MichalStrehovsky
Copy link
Member

ericstj assigned MichalStrehovsky 15 hours ago

What's the action I need to take on this?

@ericstj
Copy link
Member

ericstj commented Jan 9, 2025

Merge it when it's ready. I'll take care of that since it's now green.

@ericstj ericstj merged commit 9b2b783 into release/8.0-staging Jan 9, 2025
109 of 112 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants