-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JIT: Enable profile consistency checking up to morph #111047
JIT: Enable profile consistency checking up to morph #111047
Conversation
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
/azp run runtime-coreclr outerloop, Fuzzlyn, Antigen |
Azure Pipelines successfully started running 3 pipeline(s). |
/azp run runtime-coreclr outerloop, Fuzzlyn, Antigen |
Azure Pipelines successfully started running 3 pipeline(s). |
cc @dotnet/jit-contrib, @AndyAyersMS PTAL. Fuzzers didn't find any profile-related issues, and the outerloop runs are hitting #110958. Diffs are limited since we're missing some collections, though they're still fairly dramatic -- I suspect most of this churn is from tail-merging based on the diffs from #110656, and from the tweaks to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Would be interested in seeing stats on how many methods are consistent through morph.
Yeah, I plan on adding metrics in the next push. After morph seems like a good place to run profile repair, since that's where we currently try to fill in the blanks with |
Part of #107749. Stopping before morph seems like a sensible place, since maintaining the profile through morph will keep throw blocks with flow into them hot -- I expect that will incur plenty of diffs.
Waiting for #111006 and #111009 to go through first.