Prefer QDate::startOfDay() over QDateTime(const QDate &)

The latter can be invalid if midnight is skipped by a spring-forward. Change-Id: Ibf98d165557229f19622774ebf9a27bb0911c7a7 Reviewed-by: Thiago Macieira <[email protected]>
dougcooper · Dec 9, 2019 · 8310981 · 8310981
1 parent c27123d
commit 8310981
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/corelib/time/qdatetime.cpp b/src/corelib/time/qdatetime.cpp
@@ -5214,7 +5214,7 @@ QDateTime QDateTime::fromString(const QString &string, Qt::DateFormat format)
         if (!date.isValid())
             return QDateTime();
         if (size == 10)
-            return QDateTime(date);
+            return date.startOfDay();
 
         Qt::TimeSpec spec = Qt::LocalTime;
         QStringRef isoString(&string);